Skip to content

Upgrade terraform-provider-confluent to v2.0.0 #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

guineveresaenger
Copy link
Contributor

@guineveresaenger guineveresaenger commented Aug 16, 2024

The automated version failed in CI. Trying this manual version instead.

Hmmm. There should be schema changes, so something is off. The issue was that upstream needed to be rebased manually.

Now the Go SDK won't build again, just like with the automated upgrade.

Edit: It turns out that the examples cache was not sensitive to a major version update, and all examples in the Go SDK did not have the new v2 in the module import.

Several things to do here:

  • update playbook
  • update upgrade-provider
  • make the bridge examples cache logic version change aware.

I'll file the followup work here.

@guineveresaenger guineveresaenger added the needs-release/major When a PR with this label merges, it initiates a release of vX+1.0.0 label Aug 16, 2024
Copy link

github-actions bot commented Aug 16, 2024

Does the PR have any schema changes?

Found 11 breaking changes:

Resources

  • 🔴 "confluentcloud:index/schemaRegistryCluster:SchemaRegistryCluster" missing

Functions

  • 🔴 "confluentcloud:index/getSchemaRegistryClusters:getSchemaRegistryClusters" signature change (pulumi.InvokeOptions)->T => (Args, pulumi.InvokeOptions)->T
  • 🔴 "confluentcloud:index/getSchemaRegistryRegion:getSchemaRegistryRegion" missing

Types

  • 🔴 "confluentcloud:index/SchemaRegistryClusterEnvironment:SchemaRegistryClusterEnvironment" missing
  • 🔴 "confluentcloud:index/SchemaRegistryClusterRegion:SchemaRegistryClusterRegion" missing
  • 🔴 "confluentcloud:index/getSchemaRegistryClusterRegion:getSchemaRegistryClusterRegion" missing
  • "confluentcloud:index/getSchemaRegistryClustersCluster:getSchemaRegistryClustersCluster":
    • 🟡 properties: "regions" missing
    • required:
      • 🟢 "cloud" property has changed to Required
      • 🟢 "region" property has changed to Required
      • 🟢 "regions" property is no longer Required
  • 🔴 "confluentcloud:index/getSchemaRegistryClustersClusterRegion:getSchemaRegistryClustersClusterRegion" missing
    No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@guineveresaenger guineveresaenger marked this pull request as draft August 16, 2024 22:20
@guineveresaenger guineveresaenger marked this pull request as ready for review August 19, 2024 16:51
@guineveresaenger guineveresaenger merged commit ef801e9 into main Aug 19, 2024
22 checks passed
@guineveresaenger guineveresaenger deleted the upgrade-to-v2-major branch August 19, 2024 17:38
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v2.0.0.

@github-actions github-actions bot removed the needs-release/major When a PR with this label merges, it initiates a release of vX+1.0.0 label Aug 19, 2024
guineveresaenger added a commit to pulumi/upgrade-provider that referenced this pull request Sep 13, 2024
Update: Apologies for the delay here; see
pulumi/pulumi-terraform-bridge#2323.

pulumi/pulumi-confluentcloud#559 failed because
the upgrade process was using an old examples cache locally.
As a result, the Go SDK was generated with old version paths in the
examples code, which failed the Clean Worktree check.
The upgrade-provider tool should remove the cache to ensure we're
generating examples correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants