-
Notifications
You must be signed in to change notification settings - Fork 24
Add Mise to pulumi-java
#1717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mise to pulumi-java
#1717
Conversation
| node = "20" | ||
| "npm:pnpm" = "latest" | ||
| "npm:typescript" = "latest" | ||
| "npm:typescript-language-server" = "latest" | ||
| "npm:yarn" = "latest" | ||
| python = "3.11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required to build Java?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been a bit cautious since the pulumi submodule means that in theory you may be dipping in and out of the "full monorepo" at points and it's (IMO) handy to have a superset of that tooling available. But I'm happy if we think this is a bad call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoudl we add dotnet too in that case? I'm fine either way to be clear, happy to get this in eithre way.
|
I got the following error on this branch: Do I need to do some extra setup? |
This change adds a `.mise.toml` to the repository so that [Mise](https://mise.jdx.dev) can be used to manage developer tooling for `pulumi-java`. This is inline with other PRs across our estate, such as pulumi/pulumi#18626. Developers with Mise installed can now run `mise trust` in `pulumi-java` and have the relevant tooling installed for running `make`, etc.
blampe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should turn on Renovate's mise support if we haven't already. It can handle bumping these tools for us.
|
We have added mise to this repo. |
This change adds a
.mise.tomlto the repository so that Mise can be used to manage developer tooling forpulumi-java. This is inline with other PRs across our estate, such as pulumi/pulumi#18626. Developers with Mise installed can now runmise trustinpulumi-javaand have the relevant tooling installed for runningmake, etc.