Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

allow hyphens (-) when auto-naming the container #68

Open
Iced-Sun opened this issue May 3, 2021 · 0 comments
Open

allow hyphens (-) when auto-naming the container #68

Iced-Sun opened this issue May 3, 2021 · 0 comments
Labels
kind/enhancement Improvements or new features

Comments

@Iced-Sun
Copy link

Iced-Sun commented May 3, 2021

Affected feature

The generated container names are extracted by the regex /(.*\/|^)(?<image>\w+)(:(?<tag>.*))?/, which skips hyphens. Since most docker images use hyphens rather than underscores (e.g., cert-manager, external-dns, aws-load-banlance-controller), the regex just extracts the first word.

Is there any consideration that stops including hyphens?

@Iced-Sun Iced-Sun added the kind/enhancement Improvements or new features label May 3, 2021
@justinvp justinvp added kind/enhancement Improvements or new features and removed kind/enhancement Improvements or new features labels May 4, 2021
prom3theu5 added a commit to prom3theu5/pulumi-kubernetesx that referenced this issue Mar 12, 2022
Fixed pulumi#68
Parse image name and include hyphens.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants