You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
With some systems, such as high-mass high-speed flywheels, the built-in motor PID controllers can have significant oscillation. Allowing for controllers to directly set motor velocities gives an option for more direct control, while still being safe.
Describe the solution you'd like
An inner class to AbstractMotor which implements ControllerOutput which directly sets voltage.
Pros:
Similar to AbstractMotor::getEncoder for getting controller inputs
Can prevent duplication of
Describe alternatives you've considered
A subtype of Motor – this is the implementation I use in my own project.
Pros:
The motor can be passed into Controller builders rather than manual instantiation
Problems:
A duplicate wrapper would be necessary for MotorGroups
It isn't technically a subtype of Motor
An external wrapper class
Pros:
Straightforward
Cons:
Multiple such wrappers may be instantiated and compete
Is your feature request related to a problem? Please describe.
With some systems, such as high-mass high-speed flywheels, the built-in motor PID controllers can have significant oscillation. Allowing for controllers to directly set motor velocities gives an option for more direct control, while still being safe.
Describe the solution you'd like
An inner class to
AbstractMotor
which implementsControllerOutput
which directly sets voltage.Pros:
AbstractMotor::getEncoder
for getting controller inputsDescribe alternatives you've considered
A subtype of Motor – this is the implementation I use in my own project.
Pros:
Problems:
An external wrapper class
Pros:
Cons:
Versions
OkapiLib 5 / PurdueSigBots maintenance fork
The text was updated successfully, but these errors were encountered: