forked from OkapiLib/OkapiLib
-
Notifications
You must be signed in to change notification settings - Fork 8
Open
Description
Describe the bug
The 5 logging type LoggerTests fail.
Expected equality of these values:
line
Which is: NULL
"EMPTY_FILE"
Inspection reveals that the getline fails:
.../OkapiLib/test/loggerTests.cpp:52: Failure
Expected: (getline(&line, &len, logFile)) != ((-1)), actual: -1 vs -1
Flushing or rewinding the buffer does not help.
Additionally, LoggerTest.TestLazyLogging succeeds, but only because it does not test the output. To check if lazy logging actually works, it should probably test the output.
Steps To Reproduce
Run the LoggerTest tests:
$ ./OkapiLibV5 --gtest_filter="LoggerTest*"
Expected behavior
Tests should pass and getline should not fail to read from the file
Versions
OkapiLib 5 / PurdueSigBots maintenance fork
Additional Information
Compiled with Clang.
Metadata
Metadata
Assignees
Labels
No labels