Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

propagate execution errors up as notifications #8

Open
HotelCalifornia opened this issue Feb 25, 2019 · 1 comment
Open

propagate execution errors up as notifications #8

HotelCalifornia opened this issue Feb 25, 2019 · 1 comment

Comments

@HotelCalifornia
Copy link
Contributor

in purduesigbots/pros-atom3#38, we saw that click's error message relating to atom's locale setting was hidden in the debug console. had the error message been shown to the user, it's possible they would have been able to fix the issue themselves by following the instructions here.

I'm not really sure why that error didn't make it up as a notification, but it definitely should be one

@HotelCalifornia
Copy link
Contributor Author

relevant lines here:

for (var line of raw.split(EOL)) {
if(!line.startsWith(PREFIX)) {
console.error(line);
continue;
}

this should probably be refactored so that we don't just spam every line as its own message, as seen here:

screen shot 2019-02-25 at 4 35 17 pm

but I'm not really sure the best way to go about it. in theory, some error messages could appear in the middle of normal execution

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant