🐛 Increase max text length for controller text setting #683
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
this would be nice to have |
WillXuCodes
requested changes
Nov 19, 2024
| @@ -19,6 +19,7 @@ | |||
| #include "vdml/vdml.h" | |||
|
|
|||
| #define CONTROLLER_MAX_COLS 15 | |||
| #define CONTROLLER_MAX_CHARS 31 | |||
There was a problem hiding this comment.
A couple of nits:
- Might as well get rid of CONTROLLER_MAX_COLS
- Parenthesize and unsign the define
Other than that this looks good, thanks for the contribution :)
Suggested change
| #define CONTROLLER_MAX_CHARS 31 | |
| #define CONTROLLER_MAX_CHARS ( 31U ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changes max length of controller text to 31 characters.
Motivation:
VEXCode allows users to set controller text with a maximum length of 31 characters, but PROS caps controller text at 15 characters.
References (optional):
Close #679
Test Plan: