-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added spark updater #2191
base: master
Are you sure you want to change the base?
Added spark updater #2191
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2191 +/- ##
==========================================
- Coverage 71.75% 70.45% -1.31%
==========================================
Files 136 148 +12
Lines 19978 23919 +3941
==========================================
+ Hits 14336 16851 +2515
- Misses 5642 7068 +1426
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will sparkUpdater.sh know that there is a Spark update available? It doesn't look like it checks the plist file in the cloud.
@mfiess I have updated script to use UPDATE_URL to download software_update.plist and install spark from code_base url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to have below similar blocks kept in common function:
CURRENT_PRODUCT_ID=$line
if [[ $CURRENT_PRODUCT_ID =~ $regex ]]
then
CURRENT_PRODUCT_ID=${BASH_REMATCH[1]}
fi
idx=""
something like:
CURRENT_PRODUCT_ID=fn(line, pattern)
CURRENT_VERSION=fn(line, pattern)
CURRENT_CODEBASE =fn(line, pattern)
where pattern is like Codebase etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1, We need to copy sparkUpdater.sh from macstuff to Spark.app during build. Change is needed in mkapp.sh
2, Command line arguments number need to be changed to odd numbers $3,$5,$7 and may need to check failure case like empty inputs etc.
Thanks @madanagopalt for pointing that out as i missed changes in mkapp.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add checks for empty inputs to .sh file.
No description provided.