Skip to content

Custom CI test #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mchikina opened this issue Mar 14, 2025 · 5 comments
Open

Custom CI test #230

mchikina opened this issue Mar 14, 2025 · 5 comments

Comments

@mchikina
Copy link
Contributor

How can I implement a custom CI test to use with PC. It seems that only built in tests are supported now.

@kunwuz
Copy link
Collaborator

kunwuz commented Mar 14, 2025

#202 this is a good example written by @OliverSchacht

@mchikina
Copy link
Contributor Author

This is a PR. I wasn't planning on modifying the package code but just wanted to test some things out. Is there no way to do that in the python version.

@kunwuz
Copy link
Collaborator

kunwuz commented Mar 14, 2025

Yeah I understand that. In order to use a custom CI test, you need to wrap it as a class in cit.py, and then directly call it by changing the parameter 'indep_test' in PC. That PR could be helpful for doing that.

And you are right, there is currently no way to do it without any modification of the code.

@mchikina
Copy link
Contributor Author

Thanks. Native support for custom CI tests via a function call would be a great feature.

@kunwuz
Copy link
Collaborator

kunwuz commented Mar 14, 2025

Thanks for the great suggestion. The CI test classes in cit.py just take X, Y and condition set as input and output the p-value, for example:

class FisherZ(CIT_Base):

So, including a native support for that won't be very difficult. We will let you know when this is available. If you would like to use custom tests in the near future, the way mentioned above shouldn't be too complicated either, and I would always be happy to help if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants