Skip to content

Remove "cylindrical" macro geometry? #4856

New issue
New issue
Open
#4875
Open
Remove "cylindrical" macro geometry?#4856
#4875
@valentinsulzer

Description

@valentinsulzer
valentinsulzer
opened on Feb 17, 2025

PyBaMM/src/pybamm/geometry/battery_geometry.py

Lines 153 to 164 in 86b00ce

elif form_factor == "cylindrical":
if current_collector_dimension == 0:
geometry["current collector"] = {"r_macro": {"position": 1}}
elif current_collector_dimension == 1:
geometry["current collector"] = {
"r_macro": {"min": geo.r_inner, "max": 1},
}
else:
raise pybamm.GeometryError(
f"Invalid current collector dimension '{current_collector_dimension}' (should be 0 or 1 for "
"a 'cylindrical' battery geometry)"
)

This is not used anywhere within the repo. Is it used by an external example? @rtimms

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions