Skip to content

chore: update pre-commit hooks #5073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 24, 2025
Merged

chore: update pre-commit hooks #5073

merged 5 commits into from
Jun 24, 2025

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jun 23, 2025

@pre-commit-ci
chore: update pre-commit hooks
8c052b1 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.11.13 → v0.12.0](astral-sh/ruff-pre-commit@v0.11.13...v0.12.0)
@pre-commit-ci pre-commit-ci bot requested a review from a team as a code owner June 23, 2025 19:07
kratman
kratman previously approved these changes Jun 23, 2025
View reviewed changes
@kratman kratman dismissed their stale review June 23, 2025 19:15

CI failed

@codecov Codecov
Copy link

codecov bot commented Jun 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.58%. Comparing base (27e9257) to head (2454608).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #5073   +/-   ##
========================================
  Coverage    98.58%   98.58%           
========================================
  Files          304      304           
  Lines        23740    23740           
========================================
  Hits         23404    23404           
  Misses         336      336

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kratman
Copy link
Contributor

kratman commented Jun 23, 2025

I am testing a fix for this now

@kratman kratman marked this pull request as draft June 23, 2025 20:05
kratman
kratman reviewed Jun 24, 2025
View reviewed changes
Copy link
Contributor

@kratman kratman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should make the old and new code match

kratman
kratman reviewed Jun 24, 2025
View reviewed changes
kratman
kratman reviewed Jun 24, 2025
View reviewed changes
@kratman kratman marked this pull request as ready for review June 24, 2025 01:40
kratman
kratman approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@kratman kratman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests do cover this, but I will let somebody else take a look since I changed the code

@kratman kratman enabled auto-merge (squash) June 24, 2025 13:58
@kratman kratman merged commit 6ee089b into develop Jun 24, 2025
21 of 22 checks passed
@kratman kratman deleted the pre-commit-ci-update-config branch June 24, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kratman kratman kratman approved these changes

@MarcBerliner MarcBerliner MarcBerliner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kratman @MarcBerliner