Debug Windows build (#397)

Author: rusty1s

.github/actions/setup/action.yml

@@ -57,6 +57,12 @@ runs:
         sed -i '1s/^/#if defined(__linux__) \&\& defined(__x86_64__)\n__asm__(".symver pow,pow@GLIBC_2.2.5");\n#endif\n/' third_party/METIS/libmetis/metislib.h
       shell: bash
 
+    - name: Fix cuCollections
+      if: ${{ (inputs.cuda-version != 'cpu') && (runner.os == 'Windows') }}
+      run: |
+        sed -i '37s|#define CUCO_CUDA_MINIMUM_ARCH .*|#define CUCO_CUDA_MINIMUM_ARCH 600|' third_party/cuCollections/include/cuco/detail/__config
+      shell: bash
+
     - name: Install additional dependencies
       run: |
         pip install setuptools ninja wheel

.github/workflows/building.yml

@@ -12,28 +12,16 @@ jobs:
       matrix:
         os: [ubuntu-20.04, macos-14, windows-2019]
         python-version: ['3.9', '3.10', '3.11', '3.12']
-        # torch-version: [1.12.0, 1.13.0, 2.0.0, 2.1.0, 2.2.0, 2.3.0, 2.4.0, 2.5.0]
+        # torch-version: [1.13.0, 2.0.0, 2.1.0, 2.2.0, 2.3.0, 2.4.0, 2.5.0]
         torch-version: [2.5.0]
         cuda-version: ['cpu', 'cu113', 'cu116', 'cu117', 'cu118', 'cu121', 'cu124']
         exclude:
-          - torch-version: 1.12.0
-            python-version: '3.12'
           - torch-version: 1.13.0
             python-version: '3.12'
           - torch-version: 2.0.0
             python-version: '3.12'
           - torch-version: 2.1.0
             python-version: '3.12'
-          - torch-version: 1.12.0
-            python-version: '3.11'
-          - torch-version: 1.12.0
-            cuda-version: 'cu117'
-          - torch-version: 1.12.0
-            cuda-version: 'cu118'
-          - torch-version: 1.12.0
-            cuda-version: 'cu121'
-          - torch-version: 1.12.0
-            cuda-version: 'cu124'
           - torch-version: 1.13.0
             python-version: '3.11'
           - torch-version: 1.13.0

.github/workflows/nightly.yml

@@ -16,27 +16,15 @@ jobs:
       matrix:
         os: [ubuntu-20.04, macos-14, windows-2019]
         python-version: ['3.9', '3.10', '3.11', '3.12']
-        torch-version: [1.12.0, 1.13.0, 2.0.0, 2.1.0, 2.2.0, 2.3.0, 2.4.0, 2.5.0]
+        torch-version: [1.13.0, 2.0.0, 2.1.0, 2.2.0, 2.3.0, 2.4.0, 2.5.0]
         cuda-version: ['cpu', 'cu113', 'cu116', 'cu117', 'cu118', 'cu121', 'cu124']
         exclude:
-          - torch-version: 1.12.0
-            python-version: '3.12'
           - torch-version: 1.13.0
             python-version: '3.12'
           - torch-version: 2.0.0
             python-version: '3.12'
           - torch-version: 2.1.0
             python-version: '3.12'
-          - torch-version: 1.12.0
-            python-version: '3.11'
-          - torch-version: 1.12.0
-            cuda-version: 'cu117'
-          - torch-version: 1.12.0
-            cuda-version: 'cu118'
-          - torch-version: 1.12.0
-            cuda-version: 'cu121'
-          - torch-version: 1.12.0
-            cuda-version: 'cu124'
           - torch-version: 1.13.0
             python-version: '3.11'
           - torch-version: 1.13.0

CMakeLists.txt

@@ -43,7 +43,14 @@ if(WITH_CUDA)
   enable_language(CUDA)
   add_definitions(-DWITH_CUDA)
   set(CMAKE_CUDA_FLAGS "${CMAKE_CUDA_FLAGS} --expt-relaxed-constexpr -allow-unsupported-compiler")
-  set(CMAKE_CUDA_ARCHITECTURES "60;70;75;80;86;90")
+
+  if (CMAKE_CUDA_COMPILER_VERSION VERSION_GREATER_EQUAL 11.8)
+    set(CMAKE_CUDA_ARCHITECTURES "60;70;75;80;86;90")
+  elseif (CMAKE_CUDA_COMPILER_VERSION VERSION_GREATER_EQUAL 11.3)
+    set(CMAKE_CUDA_ARCHITECTURES "60;70;75;80;86")
+  else()
+    set(CMAKE_CUDA_ARCHITECTURES "60;70;75")
+  endif()
 
   if (NOT "$ENV{EXTERNAL_CUTLASS_INCLUDE_DIR}" STREQUAL "")
     include_directories($ENV{EXTERNAL_CUTLASS_INCLUDE_DIR})

README.md

@@ -29,7 +29,7 @@ pip install pyg-lib -f https://data.pyg.org/whl/torch-${TORCH}+${CUDA}.html
 
 where
 
-* `${TORCH}` should be replaced by either `1.12.0`, `1.13.0`, `2.0.0`, `2.1.0`, `2.2.0`, `2.3.0`, `2.4.0` or `2.5.0`
+* `${TORCH}` should be replaced by either `1.13.0`, `2.0.0`, `2.1.0`, `2.2.0`, `2.3.0`, `2.4.0` or `2.5.0`
 * `${CUDA}` should be replaced by either `cpu`, `cu102`, `cu113`, `cu116`, `cu117`, `cu118`, `cu121`, or `cu124`
 
 The following combinations are supported:
@@ -76,12 +76,6 @@ The following combinations are supported:
 | **Windows**  | ✅    |         | ✅      | ✅      |         |         |         |
 | **macOS**    | ✅    |         |         |         |         |         |         |
 
-| PyTorch 1.12 | `cpu` | `cu113` | `cu116` | `cu117` | `cu118` | `cu121` | `cu124` |
-|--------------|-------|---------|---------|---------|---------| --------|---------|
-| **Linux**    | ✅    | ✅      | ✅      |         |         |         |         |
-| **Windows**  | ✅    | ✅      | ✅      |         |         |         |         |
-| **macOS**    | ✅    |         |         |         |         |         |         |
-
 ### Form nightly
 
 Nightly wheels are provided for Linux from Python 3.9 till 3.12: