Fix builds for other backends (#1079)

Author: ofek

src/hatch/env/virtual.py

@@ -30,13 +30,13 @@ class VirtualEnvironment(EnvironmentInterface):
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
 
-        project_name = self.metadata.name
-        venv_name = project_name if self.name == 'default' else self.name
-
         # Always compute the isolated app path for build environments
         hashed_root = sha256(str(self.root).encode('utf-8')).digest()
         checksum = urlsafe_b64encode(hashed_root).decode('utf-8')[:8]
 
+        project_name = self.metadata.name if 'project' in self.metadata.config else f'{checksum}-unmanaged'
+        venv_name = project_name if self.name == 'default' else self.name
+
         # Conditions requiring a flat structure for build env
         if (
             self.isolated_data_directory == self.platform.home / '.virtualenvs'
@@ -376,7 +376,7 @@ def _python_constraint(self) -> SpecifierSet:
         # Note that we do not support this field being dynamic because if we were to set up the
         # build environment to retrieve the field then we would be stuck because we need to use
         # a satisfactory version to set up the environment
-        return SpecifierSet(self.metadata.core_raw_metadata.get('requires-python', ''))
+        return SpecifierSet(self.metadata.config.get('project', {}).get('requires-python', ''))
 
     @contextmanager
     def safe_activation(self):

tests/cli/build/test_build.py

@@ -11,66 +11,111 @@
 
 
 @pytest.mark.requires_internet
-def test_other_backend(hatch, temp_dir, helpers):
-    project_name = 'My.App'
+class TestOtherBackend:
+    def test_standard(self, hatch, temp_dir, helpers):
+        project_name = 'My.App'
 
-    with temp_dir.as_cwd():
-        result = hatch('new', project_name)
-        assert result.exit_code == 0, result.output
+        with temp_dir.as_cwd():
+            result = hatch('new', project_name)
+            assert result.exit_code == 0, result.output
 
-    path = temp_dir / 'my-app'
-    data_path = temp_dir / 'data'
-    data_path.mkdir()
+        path = temp_dir / 'my-app'
+        data_path = temp_dir / 'data'
+        data_path.mkdir()
 
-    project = Project(path)
-    config = dict(project.raw_config)
-    config['build-system']['requires'] = ['flit-core']
-    config['build-system']['build-backend'] = 'flit_core.buildapi'
-    config['project']['version'] = '0.0.1'
-    config['project']['dynamic'] = []
-    del config['project']['license']
-    project.save_config(config)
+        project = Project(path)
+        config = dict(project.raw_config)
+        config['build-system']['requires'] = ['flit-core']
+        config['build-system']['build-backend'] = 'flit_core.buildapi'
+        config['project']['version'] = '0.0.1'
+        config['project']['dynamic'] = []
+        del config['project']['license']
+        project.save_config(config)
 
-    build_directory = path / 'dist'
-    assert not build_directory.is_dir()
+        build_directory = path / 'dist'
+        assert not build_directory.is_dir()
 
-    with path.as_cwd(env_vars={ConfigEnvVars.DATA: str(data_path)}):
-        result = hatch('build')
+        with path.as_cwd(env_vars={ConfigEnvVars.DATA: str(data_path)}):
+            result = hatch('build')
 
-    assert result.exit_code == 0, result.output
-    assert result.output == helpers.dedent(
-        """
-        Creating environment: build
-        Checking dependencies
-        Syncing dependencies
-        """
-    )
+        assert result.exit_code == 0, result.output
+        assert result.output == helpers.dedent(
+            """
+            Creating environment: build
+            Checking dependencies
+            Syncing dependencies
+            """
+        )
 
-    assert build_directory.is_dir()
-    assert (build_directory / 'my_app-0.0.1-py3-none-any.whl').is_file()
-    assert (build_directory / 'my_app-0.0.1.tar.gz').is_file()
+        assert build_directory.is_dir()
+        assert (build_directory / 'my_app-0.0.1-py3-none-any.whl').is_file()
+        assert (build_directory / 'my_app-0.0.1.tar.gz').is_file()
 
-    build_directory.remove()
-    with path.as_cwd(env_vars={ConfigEnvVars.DATA: str(data_path)}):
-        result = hatch('build', '-t', 'wheel')
+        build_directory.remove()
+        with path.as_cwd(env_vars={ConfigEnvVars.DATA: str(data_path)}):
+            result = hatch('build', '-t', 'wheel')
 
-    assert result.exit_code == 0, result.output
-    assert not result.output
+        assert result.exit_code == 0, result.output
+        assert not result.output
 
-    assert build_directory.is_dir()
-    assert (build_directory / 'my_app-0.0.1-py3-none-any.whl').is_file()
-    assert not (build_directory / 'my_app-0.0.1.tar.gz').is_file()
+        assert build_directory.is_dir()
+        assert (build_directory / 'my_app-0.0.1-py3-none-any.whl').is_file()
+        assert not (build_directory / 'my_app-0.0.1.tar.gz').is_file()
 
-    build_directory.remove()
-    with path.as_cwd(env_vars={ConfigEnvVars.DATA: str(data_path)}):
-        result = hatch('build', '-t', 'sdist')
+        build_directory.remove()
+        with path.as_cwd(env_vars={ConfigEnvVars.DATA: str(data_path)}):
+            result = hatch('build', '-t', 'sdist')
 
-    assert result.exit_code == 0, result.output
-    assert not result.output
+        assert result.exit_code == 0, result.output
+        assert not result.output
+
+        assert build_directory.is_dir()
+        assert not (build_directory / 'my_app-0.0.1-py3-none-any.whl').is_file()
+        assert (build_directory / 'my_app-0.0.1.tar.gz').is_file()
+
+    def test_legacy(self, hatch, temp_dir, helpers):
+        path = temp_dir / 'tmp'
+        path.mkdir()
+        data_path = temp_dir / 'data'
+        data_path.mkdir()
+
+        (path / 'pyproject.toml').write_text(
+                """\
+[build-system]
+requires = ["setuptools"]
+build-backend = "setuptools.build_meta"
+"""
+        )
+        (path / 'setup.py').write_text(
+                """\
+import setuptools
+setuptools.setup(name="tmp", version="0.0.1")
+"""
+        )
+        (path / 'tmp.py').write_text(
+                """\
+print("Hello World!")
+"""
+        )
 
-    assert build_directory.is_dir()
-    assert not (build_directory / 'my_app-0.0.1-py3-none-any.whl').is_file()
-    assert (build_directory / 'my_app-0.0.1.tar.gz').is_file()
+        build_directory = path / 'dist'
+        assert not build_directory.is_dir()
+
+        with path.as_cwd(env_vars={ConfigEnvVars.DATA: str(data_path)}):
+            result = hatch('build')
+
+        assert result.exit_code == 0, result.output
+        assert result.output == helpers.dedent(
+            """
+            Creating environment: build
+            Checking dependencies
+            Syncing dependencies
+            """
+        )
+
+        assert build_directory.is_dir()
+        assert (build_directory / 'tmp-0.0.1-py3-none-any.whl').is_file()
+        assert (build_directory / 'tmp-0.0.1.tar.gz').is_file()
 
 
 @pytest.mark.allow_backend_process