Honor env.features when skip-install is set (#826)

* Honor env.features when skip-install is set Fixes: #729 * add release note --------- Co-authored-by: Ofek Lev <[email protected]>
pypa · Nov 26, 2023 · 9c753a5 · 9c753a5
1 parent 4f4f5b2
commit 9c753a5
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 3 deletions.
diff --git a/docs/history/hatch.md b/docs/history/hatch.md
@@ -24,6 +24,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Add `dependency_hash` method to the `environment` interface
 - The state of installed dependencies for environments is saved as metadata so if dependency definitions have not changed then no checking is performed, which can be computationally expensive
 - The `build` command now supports backends other than Hatchling
+- Allow the use of `features` for environments when `skip-install` is enabled
 - The default is now `__TOKEN__` when prompting for a username for the `publish` command
 - Bump the minimum supported version of Hatchling to 1.17.1
 - Bump the minimum supported version of `click` to 8.0.6

diff --git a/src/hatch/env/plugin/interface.py b/src/hatch/env/plugin/interface.py
@@ -310,12 +310,13 @@ def dependencies_complex(self):
 
             # Ensure these are checked last to speed up initial environment creation since
             # they will already be installed along with the project
-            if not self.skip_install and self.dev_mode:
+            if (not self.skip_install and self.dev_mode) or self.features:
                 from hatch.utils.dep import get_project_dependencies_complex
 
                 dependencies_complex, optional_dependencies_complex = get_project_dependencies_complex(self)
 
-                all_dependencies_complex.extend(dependencies_complex.values())
+                if not self.skip_install and self.dev_mode:
+                    all_dependencies_complex.extend(dependencies_complex.values())
 
                 for feature in self.features:
                     if feature not in optional_dependencies_complex:
@@ -336,7 +337,8 @@ def dependencies(self) -> list[str]:
         """
         The list of all [project dependencies](../../config/metadata.md#dependencies) (if
         [installed](../../config/environment/overview.md#skip-install) and in
-        [dev mode](../../config/environment/overview.md#dev-mode)) and
+        [dev mode](../../config/environment/overview.md#dev-mode)), selected
+        [optional dependencies](../../config/environment/overview.md#features), and
         [environment dependencies](../../config/environment/overview.md#dependencies).
         """
         if self._dependencies is None:

diff --git a/tests/env/plugin/test_interface.py b/tests/env/plugin/test_interface.py
@@ -958,6 +958,42 @@ def test_full_skip_install(self, isolation, isolated_data_dir, platform):
 
         assert environment.dependencies == ['dep2', 'dep3']
 
+    def test_full_skip_install_and_features(self, isolation, isolated_data_dir, platform):
+        config = {
+            'project': {
+                'name': 'my_app',
+                'version': '0.0.1',
+                'dependencies': ['dep1'],
+                'optional-dependencies': {'feat': ['dep4']},
+            },
+            'tool': {
+                'hatch': {
+                    'envs': {
+                        'default': {
+                            'dependencies': ['dep2'],
+                            'extra-dependencies': ['dep3'],
+                            'skip-install': True,
+                            'features': ['feat'],
+                        }
+                    }
+                }
+            },
+        }
+        project = Project(isolation, config=config)
+        environment = MockEnvironment(
+            isolation,
+            project.metadata,
+            'default',
+            project.config.envs['default'],
+            {},
+            isolated_data_dir,
+            isolated_data_dir,
+            platform,
+            0,
+        )
+
+        assert environment.dependencies == ['dep2', 'dep3', 'dep4']
+
     def test_full_dev_mode(self, isolation, isolated_data_dir, platform):
         config = {
             'project': {'name': 'my_app', 'version': '0.0.1', 'dependencies': ['dep1']},