Skip to content

Commit 7eb71fa

Browse files
authored
ci: Test packaging flow on Windows (#13184)
Most of pip's maintainers use non-Windows environments, so it's easy for our tooling to regress on Windows. Let's avoid that for our release flow. In addition, remove the dependency on the packaging job by the test jobs. The packaging job rarely fails so we aren't saving any CI resources by failing early if the packaging job fails.
1 parent e00c510 commit 7eb71fa

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

Diff for: .github/workflows/ci.yml

+6-3
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,11 @@ jobs:
6363
if: github.event_name == 'pull_request'
6464

6565
packaging:
66-
name: packaging
67-
runs-on: ubuntu-22.04
66+
name: packaging / ${{ matrix.os }}
67+
runs-on: ${{ matrix.os }}
68+
strategy:
69+
matrix:
70+
os: [ubuntu-22.04, windows-latest]
6871

6972
steps:
7073
- uses: actions/checkout@v4
@@ -104,7 +107,7 @@ jobs:
104107
name: tests / ${{ matrix.python.key || matrix.python }} / ${{ matrix.os }}
105108
runs-on: ${{ matrix.os }}
106109

107-
needs: [packaging, determine-changes]
110+
needs: [determine-changes]
108111
if: >-
109112
needs.determine-changes.outputs.tests == 'true' ||
110113
github.event_name != 'pull_request'

0 commit comments

Comments
 (0)