pipx reinstall: An exception will now be raised if package is pinned (#1674)

* feat: add --unpin option to reinstall command to allow reinstalling pinned package

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix assertion message in reinstall test

Updated error message assertion for reinstall test.

* Remove --unpin

* Update test

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: dukecat0

changelog.d/1611.bugfix.md

@@ -0,0 +1 @@
+`pipx reinstall`: An exception will now be raised if package is pinned.

src/pipx/commands/reinstall.py

@@ -54,6 +54,9 @@ def reinstall(
     else:
         package_or_url = venv.main_package_name
 
+    if venv.pipx_metadata.main_package.pinned:
+        raise PipxError(f"{error} Package {venv_dir} is pinned. Run `pipx unpin {venv_dir.name}` to unpin it first.")
+
     uninstall(venv_dir, local_bin_dir, local_man_dir, verbose)
 
     # in case legacy original dir name

tests/test_reinstall.py

@@ -68,3 +68,16 @@ def test_reinstall_with_path(pipx_temp_env, capsys, tmp_path):
     captured = capsys.readouterr()
 
     assert "Expected the name of an installed package" in captured.err.replace("\n", " ")
+
+
+def test_reinstall_pinned_package(pipx_temp_env, capsys):
+    assert not run_pipx_cli(["install", "black"])
+    assert not run_pipx_cli(["pin", "black"])
+    assert run_pipx_cli(["reinstall", "black"])
+    captured = capsys.readouterr()
+    assert "pinned" in captured.err
+
+    assert not run_pipx_cli(["unpin", "black"])
+    assert not run_pipx_cli(["reinstall", "black"])
+    captured = capsys.readouterr()
+    assert "installed package black" in captured.out