Skip to content

Commit 82ae9df

Browse files
committed
Remove --unpin
1 parent 05a4b68 commit 82ae9df

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

changelog.d/1611.bugfix.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
`pipx reinstall`: An exception will now be raised if package is pinned. `--unpin` option is introduced to allow reinstalling pinned package
1+
`pipx reinstall`: An exception will now be raised if package is pinned.

src/pipx/commands/reinstall.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ def reinstall(
2727
verbose: bool,
2828
force_reinstall_shared_libs: bool = False,
2929
python_flag_passed: bool = False,
30-
unpin: bool = False,
3130
) -> ExitCode:
3231
"""Returns pipx exit code."""
3332
if not venv_dir.exists():
@@ -55,8 +54,8 @@ def reinstall(
5554
else:
5655
package_or_url = venv.main_package_name
5756

58-
if venv.pipx_metadata.main_package.pinned and not unpin:
59-
raise PipxError(f"{error} Package {venv_dir} is pinned. Pass --unpin to unpin and reinstall it.")
57+
if venv.pipx_metadata.main_package.pinned:
58+
raise PipxError(f"{error} Package {venv_dir} is pinned. Run `pipx unpin {venv_dir.name}` to unpin it first.")
6059

6160
uninstall(venv_dir, local_bin_dir, local_man_dir, verbose)
6261

src/pipx/main.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,6 @@ def run_pipx_command(args: argparse.Namespace, subparsers: Dict[str, argparse.Ar
397397
python=args.python,
398398
verbose=verbose,
399399
python_flag_passed=python_flag_passed,
400-
unpin=args.unpin,
401400
)
402401
elif args.command == "reinstall-all":
403402
return commands.reinstall_all(
@@ -732,7 +731,6 @@ def _add_reinstall(subparsers, venv_completer: VenvCompleter, shared_parser: arg
732731
parents=[shared_parser],
733732
)
734733
p.add_argument("package").completer = venv_completer
735-
p.add_argument("--unpin", action="store_true", help="Unpin and reinstall the package if it is pinned.")
736734
add_python_options(p)
737735

738736

0 commit comments

Comments
 (0)