pipx install --editable: fix regression (#323)

* Put --no-dependencies first in pip args in `install_package_no_deps()` in `venv.py`.
* Move --editable to last in `get_pip_args()` in `main.py`.

Author: itsayellow

docs/changelog.md

@@ -1,3 +1,7 @@
+dev
+
+- [bugfix] fix regression that caused installing with --editable flag to fail package name determination.
+
 0.15.1.0
 
 - Add Python 3.8 to PyPI classifier and travis test matrix

src/pipx/main.py

@@ -102,11 +102,13 @@ def get_pip_args(parsed_args: Dict) -> List[str]:
     if parsed_args.get("index_url"):
         pip_args += ["--index-url", parsed_args["index_url"]]
 
-    if parsed_args.get("editable"):
-        pip_args += ["--editable"]
-
     if parsed_args.get("pip_args"):
         pip_args += shlex.split(parsed_args.get("pip_args", ""))
+
+    # make sure --editable is last because it needs to be right before
+    #   package specification
+    if parsed_args.get("editable"):
+        pip_args += ["--editable"]
     return pip_args
 
 

src/pipx/venv.py

@@ -216,7 +216,7 @@ def install_package_no_deps(self, package_or_url: str, pip_args: List[str]) -> s
                 f"determining package name from {package_or_url!r}", self.do_animation
             ):
                 old_package_set = self.list_installed_packages()
-                cmd = ["install"] + pip_args + ["--no-dependencies"] + [package_or_url]
+                cmd = ["install"] + ["--no-dependencies"] + pip_args + [package_or_url]
                 self._run_pip(cmd)
         except PipxError as e:
             logging.info(e)