Fix combining of --editable and --force flag (#1124)

* Fix combining of `--editable` and `--force` flag

The 1.3.0 version of `pipx` (with #933) introduced a but where
the `--force-reinstall` flag caused failure when also
the `--editable` flag was used - because it was adding the
`--force-reinstall` flag after `--editable` one (and `--editable`
flag expects url/path to the Python package to install to follow it.

The change fixes it by adding the `--force-reinstall` flag at the
beginning rather than at the end of arguments to avoid this
kind of problem also in case other flags might have similar problem.

Fixes: #1122

* fixup! Fix combining of `--editable` and `--force` flag

Author: potiuk

.gitignore

@@ -17,4 +17,6 @@ docs/docs.md
 pipx.1
 .pipx_tests
 /.coverage*
-testdata
+/testdata
+!/testdata/empty_project
+/.idea

CHANGELOG.md

@@ -1,5 +1,7 @@
 ## dev
 
+- Fix combining of --editable and --force flag
+
 ## 1.3.0
 
 - Check whether pip module exists in shared lib before performing any actions, such as `reinstall-all`.

src/pipx/commands/install.py

@@ -58,7 +58,7 @@ def install(
             )
         if force:
             print(f"Installing to existing venv {venv.name!r}")
-            pip_args += ["--force-reinstall"]
+            pip_args = ["--force-reinstall"] + pip_args
         else:
             print(
                 pipx_wrap(

testdata/empty_project/README.md

@@ -0,0 +1 @@
+Empty project used for testing only

testdata/empty_project/empty_project/__init__.py

@@ -0,0 +1,6 @@
+def main():
+    pass
+
+
+if __name__ == "__main__":
+    main()

testdata/empty_project/empty_project/main.py

@@ -0,0 +1,21 @@
+[build-system]
+requires = [
+  "setuptools",
+  "wheel",
+]
+
+[project]
+name = "empty-project"
+version = "0.1.0"
+description = "Empty Python Project"
+authors = [{ name = "My Name", email = "[email protected]" }]
+requires-python = ">=3.8"
+classifiers = [
+  "Programming Language :: Python :: 3 :: Only",
+  "Programming Language :: Python :: 3.8",
+  "Programming Language :: Python :: 3.9",
+  "Programming Language :: Python :: 3.10",
+  "Programming Language :: Python :: 3.11",
+  "Programming Language :: Python :: 3.12",
+]
+scripts.empty-project = "empty_project.main:cli"

testdata/empty_project/pyproject.toml

@@ -285,6 +285,17 @@ def test_force_install_changes(pipx_temp_env, capsys):
     assert "2022.1.7" not in captured.out
 
 
+def test_force_install_changes_editable(pipx_temp_env, root, capsys):
+    empty_project_path_as_string = (root / "testdata" / "empty_project").as_posix()
+    assert not run_pipx_cli(["install", "--editable", empty_project_path_as_string])
+    captured = capsys.readouterr()
+    assert "empty-project" in captured.out
+
+    assert not run_pipx_cli(["install", "--editable", empty_project_path_as_string, "--force"])
+    captured = capsys.readouterr()
+    assert "Installing to existing venv 'empty-project'" in captured.out
+
+
 def test_preinstall(pipx_temp_env, caplog):
     assert not run_pipx_cli(["install", "--preinstall", "black", "nox"])
     assert "black" in caplog.text