From 093af8c72b21a2387fe94f28a47ab94d9b550e17 Mon Sep 17 00:00:00 2001 From: Avasam Date: Thu, 31 Oct 2024 10:00:43 -0400 Subject: [PATCH] Disallow blanket and unused suppressions (PGH, RUF10) --- ruff.toml | 2 ++ setuptools/_distutils/compat/py38.py | 2 +- setuptools/tests/config/test_apply_pyprojecttoml.py | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ruff.toml b/ruff.toml index 438c048962..f6b11962f1 100644 --- a/ruff.toml +++ b/ruff.toml @@ -19,7 +19,9 @@ extend-select = [ "FA", # flake8-future-annotations "I", # isort "PERF", # Perflint + "PGH", # pygrep-hooks (blanket-* rules) "PYI", # flake8-pyi + "RUF10", # unused-noqa & redirected-noqa "TRY", # tryceratops "UP", # pyupgrade "YTT", # flake8-2020 diff --git a/setuptools/_distutils/compat/py38.py b/setuptools/_distutils/compat/py38.py index 03ec73ef0e..afe5345553 100644 --- a/setuptools/_distutils/compat/py38.py +++ b/setuptools/_distutils/compat/py38.py @@ -26,7 +26,7 @@ def removeprefix(self, prefix): def aix_platform(osname, version, release): try: - import _aix_support # type: ignore + import _aix_support return _aix_support.aix_platform() except ImportError: diff --git a/setuptools/tests/config/test_apply_pyprojecttoml.py b/setuptools/tests/config/test_apply_pyprojecttoml.py index deee6fa47c..d18ba6e129 100644 --- a/setuptools/tests/config/test_apply_pyprojecttoml.py +++ b/setuptools/tests/config/test_apply_pyprojecttoml.py @@ -17,7 +17,7 @@ from ini2toml.api import LiteTranslator from packaging.metadata import Metadata -import setuptools # noqa ensure monkey patch to metadata +import setuptools # noqa: F401 # ensure monkey patch to metadata from setuptools.command.egg_info import write_requirements from setuptools.config import expand, pyprojecttoml, setupcfg from setuptools.config._apply_pyprojecttoml import _MissingDynamic, _some_attrgetter