Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Broken: Restart On Code Update #11

Open
johnemajor opened this issue Aug 15, 2019 · 2 comments
Open

Feature Broken: Restart On Code Update #11

johnemajor opened this issue Aug 15, 2019 · 2 comments

Comments

@johnemajor
Copy link

The old show runner//cherrypy would re-read the code and re-start when edits were made while the show runner was running. Now if a file is changed, the show runner stalls with:
[15/Aug/2019:01:17:26] ENGINE Waiting for child threads to terminate...
INFO:cherrypy.error:[15/Aug/2019:01:17:26] ENGINE Waiting for child threads to terminate...
[15/Aug/2019:01:17:26] ENGINE Waiting for thread sACN sending/sender thread.
INFO:cherrypy.error:[15/Aug/2019:01:17:26] ENGINE Waiting for thread sACN sending/sender thread.

This had been a quite useful feature.

@sul3n3t
Copy link

sul3n3t commented Aug 16, 2019

Here's a link to the prior show loader.

It wasn't doing anything in particular with file modification times. It was dynamically loading code from a directory, but memoizing the call, so it didn't actually execute very often.

@sul3n3t
Copy link

sul3n3t commented Aug 16, 2019

Leaving as another note, this entr command-line tool could trivially restart the process on file change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants