Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow python 3.12 for last releases of pyRDDLGym [feature-request] #264

Open
nhuet opened this issue Nov 4, 2024 · 6 comments · May be fixed by #265
Open

Allow python 3.12 for last releases of pyRDDLGym [feature-request] #264

nhuet opened this issue Nov 4, 2024 · 6 comments · May be fixed by #265
Labels
bug Something isn't working

Comments

@nhuet
Copy link

nhuet commented Nov 4, 2024

I was not able to install last release (2.1) on a python 3.12 environment, and I see that this is a requirement written in setup.py.
As a consequence, I installed the previous one 2.0 (which does not seem to have an issue working with python 3.12), which in turns is not compatible with latest pyRDDLGym-rl release...

Why is it that 2.1 requires python<3.12?
Do you plan a release soon for python 3.12?

Many thanks.

@ataitler
Copy link
Collaborator

ataitler commented Nov 4, 2024

It is not a matter of v2.1 requires lower python than 3.12 and v2.0 dot not, and more that python changed some components such as casting in v3.12, which is incompatible with all of pyRDDLGym versions. So, in version 2.1 we added the restriction of using a lower version of python.

@mike-gimelfarb
Copy link
Collaborator

I'm thinking that at some point we will have to open compatibility with 3.12 and later python versions, regardless of whether numpy will fix that on their end.

@mike-gimelfarb
Copy link
Collaborator

Please check the latest PR. I am not sure I remember exactly what the problems were but one of them with casting was that numpy can_cast was causing a crash on latest version. I have fixed this particular issue, and the code seems to run correctly in a new python 3.12 environment.

@nhuet
Copy link
Author

nhuet commented Nov 4, 2024

It is not a matter of v2.1 requires lower python than 3.12 and v2.0 dot not, and more that python changed some components such as casting in v3.12, which is incompatible with all of pyRDDLGym versions. So, in version 2.1 we added the restriction of using a lower version of python.

We probably do not use the full extent of pyRDDLGym, but in the ci/cd process of our project scikit-decide, we do use pyRDDLGym on python 3.12 environments without any issues (this is still in a PR for now).

@mike-gimelfarb
Copy link
Collaborator

I believe the numpy casting checks were added sometime after v 2.0 was released, so is it possible you were testing on pyrddlgym 2.0? 2.1 does not work with python 3.12 on my end in a fresh environment.

@mike-gimelfarb mike-gimelfarb added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Nov 4, 2024
@nhuet
Copy link
Author

nhuet commented Nov 4, 2024

Yes i was speaking about 2.0 (since pip installing 2.1 does not work because of the python<3.12 requirement)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants