[Bug]: Set Revisions to Sheets - Sheets unchecked when scrolling

[JerryWu25]

✈ Pre-Flight checks

• I don't have SentinelOne antivirus installed (see above for the solution)
• I have searched in the issues (open and closed) but couldn't find a similar issue
• I have searched in the pyRevit Forum for similar issues
• I already followed the installation troubleshooting guide thoroughly
• I am using the latest pyRevit Version

🐞 Describe the bug

As in the gif below, I selected 2 sheets then I scroll the list up and down, the 1st sheet is deselected.

⌨ Error/Debug Message

As mentioned above

♻️ To Reproduce

1. Run Set revision to sheet
2. Select any revision
3. Select first 2 sheets
4. Scroll up and down using the scroll wheel
5. Notices the 1st sheet is deselected

⏲️ Expected behavior

No response

🖥️ Hardware and Software Setup (please complete the following information)

==> Registered Clones (full git repos)
==> Registered Clones (deployed from archive/image)
==> Attachments
Unknown | Product: "2025 First Customer Ship" | Manifest: "C:\ProgramData\Autodesk\Revit\Addins\2025\pyRevit.addin"
Unknown | Product: "2024.3.1" | Manifest: "C:\ProgramData\Autodesk\Revit\Addins\2024\pyRevit.addin"
Unknown | Product: "Autodesk Revit 2023" | Manifest: "C:\ProgramData\Autodesk\Revit\Addins\2023\pyRevit.addin"
Unknown | Product: "Autodesk Revit 2022" | Manifest: "C:\ProgramData\Autodesk\Revit\Addins\2022\pyRevit.addin"
==> Installed Extensions
==> Default Extension Search Path
C:\Users\xxx\AppData\Roaming\pyRevit\Extensions
==> Extension Search Paths
==> Extension Sources - Default
https://github.com/pyrevitlabs/pyRevit/raw/master/extensions/extensions.json
==> Extension Sources - Additional
==> Installed Revits
2025 First Customer Ship | Version: 25.0.2.419 | Build: 20240307_1300(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2025\"
2024.3.1 | Version: 24.3.10.22 | Build: 20241105_1515(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2024\"
Autodesk Revit 2023 | Version: 23.1.60.36 | Build: 20241107_1515(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2023\"
Autodesk Revit 2022 | Version: 22.1.80.32 | Build: 20241107_1515(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2022\"
==> Running Revit Instances
Error: Object reference not set to an instance of an object.
Run with "--debug" option to see debug messages

Additional context

No response

[jmcouffin]

I cannot reproduce.
What version of pyRevit are you using?

[JerryWu25]

I cannot reproduce. What version of pyRevit are you using?

Pyrevit CLI 5.0.1.25051

[jmcouffin]

Can you provide a minimal Revit file with which you can reproduce + list of other plugins installed + Revit version being used for this bug?

[JerryWu25]

Can you provide a minimal Revit file with which you can reproduce + list of other plugins installed + Revit version being used for this bug?

I tried it on Revit 23 and 25 on a few projects, even the Revit Sample file one, I only have Ideate addin turned on now.
I think to recreate it exactly, you will need to highlight the sheet first, then scroll up and down, as you can see in the gif, after I scroll, the checkbox is back to checked without clicking.

[jmcouffin]

There you go.
I managed to reproduce. This is a real bug. 😄

[jmcouffin]

The state management is improperly implemented. When the item unchecked becomes out of focus when scrolling down, it does not remember its new state, so that when scrolling back up, it comes back to its checked state.

[jmcouffin]

bug introduced:
jmcouffin@f370ede#diff-b655b2965d511e3cd2fa97e441c9876a7bb25d8d8be6d1d0244887adaaa49ccdR135

Setting Recycling to Standard should do the trick with a reasonable performance hit.