Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ripley.py vs distance_statistics.py duplication? #108

Closed
martinfleis opened this issue Jul 2, 2023 · 1 comment
Closed

ripley.py vs distance_statistics.py duplication? #108

martinfleis opened this issue Jul 2, 2023 · 1 comment

Comments

@martinfleis
Copy link
Member

Hey,

I wanted to remove old deprecated classes Ripley's functions that are now in _deprecated_distance_statistics.py`.

While doing that, I noticed that the new implementation seems to live in distance_statistics.py but then we have nearly exactly the same code also in ripley.py.

distance_statistics.py has more complete docstrings and is included in API docs, while ripley.py has some additional utils.

Is it safe to remove ripley.py from the codebase? It is not tested (0% coverage) but it is used in the distance_statistics-numpy-oriented.ipynb notebook.

The distance_statistics.ipynb notebooks will also need to be updated to point to new functions from the deprecated classes.

@ljwolf I suppose you will know the answers. I thought that the contents of ripley.py has been moved to distance_statistics.py and never removed from the original location but there are more recent comments to ripley.py than to distance_statistics.py so I am a bit confused.

@martinfleis
Copy link
Member Author

I noticed #105 now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant