You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Seem like adding a style_kwds keyword argument to vba_choropleth() and then passing into gdf.plot(color=rgba, ax=ax) seems to be low hanging fruit that would provide nice customization. Thoughts, @martinfleis?
fine if you want to make the change, but tbh I'd rather focus on the overhaul of splot so we can make sure all the pieces keep moving. I know we've got a handful of viz updates in the mix to update, so i'd put this near the bottom of the priorities list
Though it would be a killer gsoc project for a student to put together a bunch of examples of how to do bivariate maps well using splot by, like, recreating the examples from here
@knaaptime Seems like we could simply add in the keyword and pass directly into the plotting function. IMO, no tests are even needed since it's a GeoPandas thing at that point. If you agree, I think it is a no brainer to add – and I will do that. If there would be any kind of testing needed for this addition, then I agree it would be better to hold off for now. Let me know.
Seem like adding a
style_kwds
keyword argument tovba_choropleth()
and then passing intogdf.plot(color=rgba, ax=ax)
seems to be low hanging fruit that would provide nice customization. Thoughts, @martinfleis?cc @jvtcl
The text was updated successfully, but these errors were encountered: