fix linting

Author: pysel

balancer/balancer.go

@@ -133,7 +133,10 @@ func (b *Balancer) Get(ctx context.Context, key []byte) (*prototypes.GetResponse
 					offlineAddressesErr.Errors = append(offlineAddressesErr.Errors, err)
 
 					// TODO: consider tombstoning before removing
-					rangeView.RemovePartition(rangeView.Addresses[i])
+					err := rangeView.RemovePartition(rangeView.Addresses[i])
+					if err != nil {
+						return nil, err
+					}
 				}
 			}
 			continue

client/client_test.go

@@ -12,7 +12,6 @@ import (
 )
 
 var (
-	// zero = uint64(0)
 	one = uint64(1)
 )
 

partition/2pc.go

@@ -22,10 +22,10 @@ func (ls *ListenServer) PrepareCommit(ctx context.Context, req *pbpartition.Prep
 
 func (ls *ListenServer) AbortCommit(ctx context.Context, req *pbpartition.AbortCommitRequest) (*pbpartition.AbortCommitResponse, error) {
 	ls.lockedMessage = nil
-	ls.Partition.ProcessBacklog()
+	err := ls.Partition.ProcessBacklog()
 
 	ls.EventHandler.Emit(TwoPCAbortEvent{})
-	return &pbpartition.AbortCommitResponse{}, nil
+	return &pbpartition.AbortCommitResponse{}, err
 }
 
 func (ls *ListenServer) Commit(ctx context.Context, req *pbpartition.CommitRequest) (res *pbpartition.CommitResponse, err error) {

partition/grpc.go

@@ -13,7 +13,11 @@ import (
 
 // Set sets a value for a key.
 func (ls *ListenServer) Set(ctx context.Context, req *prototypes.SetRequest) (resp *prototypes.SetResponse, err error) {
-	defer func() { ls.postCRUD(err, req.String()) }()
+	defer func() {
+		if ls.postCRUD(err, req.String()) != nil {
+			panic("postCRUD failed")
+		}
+	}()
 
 	// note: if request is not valid, the timestamp will not be incremented
 	// TODO: investigate if it is a valid behaviour.
@@ -49,7 +53,11 @@ func (ls *ListenServer) Set(ctx context.Context, req *prototypes.SetRequest) (re
 
 // Get gets a value for a key.
 func (ls *ListenServer) Get(ctx context.Context, req *prototypes.GetRequest) (resp *prototypes.GetResponse, err error) {
-	defer func() { ls.postCRUD(err, req.String()) }()
+	defer func() {
+		if ls.postCRUD(err, req.String()) != nil {
+			panic("postCRUD failed")
+		}
+	}()
 
 	if err = req.Validate(); err != nil {
 		return nil, err
@@ -86,7 +94,11 @@ func (ls *ListenServer) Get(ctx context.Context, req *prototypes.GetRequest) (re
 
 // Delete deletes a value for a key.
 func (ls *ListenServer) Delete(ctx context.Context, req *prototypes.DeleteRequest) (resp *prototypes.DeleteResponse, err error) {
-	defer func() { ls.postCRUD(err, req.String()) }()
+	defer func() {
+		if ls.postCRUD(err, req.String()) != nil {
+			panic("postCRUD failed")
+		}
+	}()
 
 	if err = req.Validate(); err != nil {
 		return nil, err
@@ -134,20 +146,20 @@ func (ls *ListenServer) SetHashrange(ctx context.Context, req *prototypes.SetHas
 }
 
 // postCRUD runs functionality that should be run after every CRUD operation.
-func (ls *ListenServer) postCRUD(err error, req string) {
+func (ls *ListenServer) postCRUD(err error, req string) error {
 	// if error is a warning, log it as warning
 	// log error as error otherwise
 	if err != nil {
 		if eventError, ok := err.(shared.IsWarningEventError); ok {
 			ls.EventHandler.Emit(eventError.WarningErrorToEvent(req))
-			return
+			return nil
 		}
 		ls.EventHandler.Emit(shared.ErrorEvent{Req: req, Err: err})
 	} else {
 		ls.IncrTs()
 	}
 
-	ls.ProcessBacklog()
+	return ls.ProcessBacklog()
 }
 
 func (ls *ListenServer) validateTSGrpcLevel(ts uint64, message proto.Message) error {

testutil/grpc.go

@@ -116,8 +116,8 @@ func BalancerClientWith2Partitions(t *testing.T) (net.Addr, func()) {
 
 	// register partitions
 	b := balancer.NewBalancer(balancer.BalancerDBPath+t.Name(), 2)
-	b.RegisterPartition(ctx, addrs[0].String())
-	b.RegisterPartition(ctx, addrs[1].String())
+	_ = b.RegisterPartition(ctx, addrs[0].String())
+	_ = b.RegisterPartition(ctx, addrs[1].String())
 
 	server := balancer.RegisterBalancerServer(b)
 	_, addr := shared.StartListeningOnPort(server, 0)