Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move jit_stencils.h to the Python/ directory #126087

Closed
Eclips4 opened this issue Oct 28, 2024 · 2 comments
Closed

Move jit_stencils.h to the Python/ directory #126087

Eclips4 opened this issue Oct 28, 2024 · 2 comments
Labels
topic-JIT type-feature A feature request or enhancement

Comments

@Eclips4
Copy link
Member

Eclips4 commented Oct 28, 2024

Feature or enhancement

Proposal:

I don't know if there is any reason to keep jit_stencils.h under the root directory, but I think it should also be placed in the Python directory, as other generated files are also placed there (generated_cases.c.h, executor_cases.c.h, optimizer_cases.c.h).

If you agree, I will be happy to submit a PR :)

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

@Eclips4 Eclips4 added type-feature A feature request or enhancement topic-JIT labels Oct 28, 2024
@brandtbucher
Copy link
Member

brandtbucher commented Oct 29, 2024

jit_stencils.h isn't placed in the root directory, it's placed in the build directory (basically, wherever configure is run from). This is important, since (like pyconfig, or compiled .o files) it contains code specific to that particular build. In particular, out-of-tree builds, especially parallel ones, would break.

So I think it makes sense for this to stay where it is, right next to pyconfig.h. Unlike the other files you mention, it's not tracked by version control.

@Eclips4
Copy link
Member Author

Eclips4 commented Oct 29, 2024

jit_stencils.h isn't placed in the root directory, it's placed in the build directory (basically, wherever configure is run from). This is important, since (like pyconfig, or compiled .o files) it contains code specific to that particular build. In particular, out-of-tree builds, especially parallel ones, would break.

So I think it makes sense for this to stay where it is, right next to pyconfig.h. Unlike the other files you mention, it's not tracked by version control.

Oh, yes, I somehow missed it. So, there's no issue. Sorry for making noise!

@Eclips4 Eclips4 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-JIT type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants