Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-126462: Remove duplicate sentences, fix malformatted example in dataclasses "Post-init processing" section #126463

Closed

Conversation

akabraham
Copy link

@akabraham akabraham commented Nov 6, 2024

@akabraham
Copy link
Author

NOTE: changed the base branch to 3.11 instead of the default main I accidentally submitted to

@freakboy3742 freakboy3742 removed their request for review November 6, 2024 00:08
@ZeroIntensity
Copy link
Member

What on earth happened with the reviewers

@carljm carljm removed their request for review November 6, 2024 00:54
@carljm
Copy link
Member

carljm commented Nov 6, 2024

What on earth happened with the reviewers

This is what happens when a PR is opened against a branch different from the one its commit is actually on. This one was a commit on the 3.11 branch but submitted as a PR against main, so it ends up being a PR that includes every single commit in the 3.11 branch as part of the PR, and so everyone involved in all of those backport commits gets auto-added as a reviewer.

@terryjreedy
Copy link
Member

Rebasing on the correct branch and removing review requests does not unsubscribe people. It would be nice if Gh would let us block creation of such PRs.

@akabraham akabraham force-pushed the fix/dataclasses_post_init_processing branch from 894d09c to f9f6ec5 Compare November 12, 2024 14:43
@bedevere-app
Copy link

bedevere-app bot commented Nov 12, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@ZeroIntensity
Copy link
Member

I'm going to close this. 3.11 only accepts security changes, and any change to this PR notifies half the core team anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants