python.org does not validate #985
Comments
berkerpeksag
added
frontend
|
Thanks! Yes, most of them look easy. |
fix issue with role attributes
fix issue with role attributes
fix issue with role attributes
|
@berkerpeksag I'm a first timer on github and i would like to help fix this bug, could you direct me to the files to be changed and maybe tell a little bit more about the issue. |
|
Thank you for your interest for contributing to python.org. Unfortunately, there is already an open pull request to fix this: #992. Feel free to grab another issue! |
|
@berkerpeksag |
|
Hello guys, I would like to contribute to pythondotorg frontend issues. I would like to know if this PR is still valid? |
|
If you want to contribute, surely a good first step would be to check by yourself whether it is still valid (by running the W3C validator, and/or by checking the source code of the site in the web browser of your choice and comparing it with the changes in the proposed but unmerged pull request that is linked elsewhere on this issue). And then post your findings |
|
I have checked the validator and it still shows bugs and warnings. If nobody is working can this issue be assigned to me? I am a beginner and want to work on this. |
The W3C validator is rather unhappy with python.org, as one can see here: https://validator.w3.org/nu/?doc=https%3A%2F%2Fwww.python.org%2F
Now, I don't believe in "validation for validation's sake", but at least some of these look potentially serious to me -- in particular, the invalid "role" attributes. As these are used for screen readers, I wonder if this breaks screen some screen readers, and thus might impair accessibility?
Fixing those shouldn't be hard ... well, at least to fix the HTML -- I have no idea how this site is implemented, so perhaps actually making the change is much harder.
The text was updated successfully, but these errors were encountered: