Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make C++ level device interface generic (device agnostic) #605

Closed
dvrogozh opened this issue Mar 28, 2025 · 0 comments · Fixed by #606
Closed

Make C++ level device interface generic (device agnostic) #605

dvrogozh opened this issue Mar 28, 2025 · 0 comments · Fixed by #606

Comments

@dvrogozh
Copy link
Contributor

See: src/torchcodec/decoders/_core/DeviceInterface.h

Currently defined device interface is CUDA specific by naming and usage. As discussed in #559 (comment) this complicates adding support for other device backends. It does seem a right step to refactor device interface, make it generic and allow easy registration of non-CUDA device specific backends. Creating this issue to track that.

CC: @scotts, @NicolasHug
dvrogozh added a commit to dvrogozh/torchcodec that referenced this issue Mar 28, 2025
@dvrogozh
Make device interface generic
58b55e3 
Fixes: pytorch#605

Changes:
* Device interface made device agnostic by intorducing `class DeviceInterface`
  from which specific backends should inherit their device specific implementations
* Implemented `CudaDevice` derived from `DeviceInterface`
* Created device interface registration mechanism (`registerDeviceInterface`)
* Created device interface creation mechanism (`createDeviceInterface`)

These changes allow to replace CUDA specific code in `VideoDecoder.cpp` and
`VideoDecoderOps.cpp` by device agnostic code.

Signed-off-by: Dmitry Rogozhkin <[email protected]>
This was referenced Mar 28, 2025
Merged
Open
dvrogozh added a commit to dvrogozh/torchcodec that referenced this issue Apr 1, 2025
@dvrogozh
Make device interface generic
89df863 
Fixes: pytorch#605

Changes:
* Device interface made device agnostic by intorducing `class DeviceInterface`
  from which specific backends should inherit their device specific implementations
* Implemented `CudaDevice` derived from `DeviceInterface`
* Created device interface registration mechanism (`registerDeviceInterface`)
* Created device interface creation mechanism (`createDeviceInterface`)

These changes allow to replace CUDA specific code in `VideoDecoder.cpp` and
`VideoDecoderOps.cpp` by device agnostic code.

Signed-off-by: Dmitry Rogozhkin <[email protected]>
dvrogozh added a commit to dvrogozh/torchcodec that referenced this issue Apr 2, 2025
@dvrogozh
Make device interface generic
c19dac3 
Fixes: pytorch#605

Changes:
* Device interface made device agnostic by intorducing `class DeviceInterface`
  from which specific backends should inherit their device specific implementations
* Implemented `CudaDevice` derived from `DeviceInterface`
* Created device interface registration mechanism (`registerDeviceInterface`)
* Created device interface creation mechanism (`createDeviceInterface`)

These changes allow to replace CUDA specific code in `VideoDecoder.cpp` and
`VideoDecoderOps.cpp` by device agnostic code.

Signed-off-by: Dmitry Rogozhkin <[email protected]>

address comments

Signed-off-by: Dmitry Rogozhkin <[email protected]>
dvrogozh added a commit to dvrogozh/torchcodec that referenced this issue Apr 2, 2025
@dvrogozh
Make device interface generic
f7512f2 
Fixes: pytorch#605

Changes:
* Device interface made device agnostic by intorducing `class DeviceInterface`
  from which specific backends should inherit their device specific implementations
* Implemented `CudaDevice` derived from `DeviceInterface`
* Created device interface registration mechanism (`registerDeviceInterface`)
* Created device interface creation mechanism (`createDeviceInterface`)

These changes allow to replace CUDA specific code in `VideoDecoder.cpp` and
`VideoDecoderOps.cpp` by device agnostic code.

Signed-off-by: Dmitry Rogozhkin <[email protected]>

address comments

Signed-off-by: Dmitry Rogozhkin <[email protected]>

tmp

Signed-off-by: Dmitry Rogozhkin <[email protected]>
dvrogozh added a commit to dvrogozh/torchcodec that referenced this issue Apr 2, 2025
@dvrogozh
Make device interface generic
d0c7274 
Fixes: pytorch#605

Changes:
* Device interface made device agnostic by intorducing `class DeviceInterface`
  from which specific backends should inherit their device specific implementations
* Implemented `CudaDevice` derived from `DeviceInterface`
* Created device interface registration mechanism (`registerDeviceInterface`)
* Created device interface creation mechanism (`createDeviceInterface`)

These changes allow to replace CUDA specific code in `VideoDecoder.cpp` and
`VideoDecoderOps.cpp` by device agnostic code.

Signed-off-by: Dmitry Rogozhkin <[email protected]>
dvrogozh added a commit to dvrogozh/torchcodec that referenced this issue Apr 3, 2025
@dvrogozh
Make device interface generic
0143d4e 
Fixes: pytorch#605

Changes:
* Device interface made device agnostic by intorducing `class DeviceInterface`
  from which specific backends should inherit their device specific implementations
* Implemented `CudaDevice` derived from `DeviceInterface`
* Created device interface registration mechanism (`registerDeviceInterface`)
* Created device interface creation mechanism (`createDeviceInterface`)

These changes allow to replace CUDA specific code in `VideoDecoder.cpp` and
`VideoDecoderOps.cpp` by device agnostic code.

Signed-off-by: Dmitry Rogozhkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make device interface generic dvrogozh/torchcodec
1 participant
@dvrogozh