Add sample_format to audio metadata
#557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
commented
Mar 13, 2025
| @@ -90,6 +90,7 @@ def test_get_metadata(metadata_getter): | |||
| ) | |||
| assert best_audio_stream_metadata.bit_rate == 128837 | |||
| assert best_audio_stream_metadata.codec == "aac" | |||
| assert best_audio_stream_metadata.sample_format == "fltp" | |||
There was a problem hiding this comment.
Hard-coded value here and below, this test already has lots of these.
NicolasHug
commented
Mar 13, 2025
| # decoded frames. | ||
| self._reference_frames[stream_index] = torch.load( | ||
| frames_data_path, weights_only=True | ||
| ) |
There was a problem hiding this comment.
I'll add the corresponding reference frames in #556
NicolasHug
commented
Mar 13, 2025
There was a problem hiding this comment.
Also adding this new asset, not strictly needed for this PR, but still useful to check a format that's not fltp.
It will be needed in #556 anyway. It's from TorchAudio.
scotts
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #549
This PR adds the
sample_formatfield toAudioStreamMetadata. In terms of values, it'll be whatav_get_sample_fmt_name()returns, so it's a bit "ffmpeg-like": flt, fltp, s16, s32... Maybe we'll want to expose a more user-friendly string? I'm not sure, either way, we can always re-map as follow-ups.