fix row-wise alltoall error when some embeddings use mean pooling and others use sum pooling#2809
Closed
tiankongdeguiji wants to merge 1 commit intometa-pytorch:mainfrom
Closed
Conversation
… others use sum pooling
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
hi, @iamzainhuda @henrylhtsang @PaulZhang12 @joshuadeng could you take a look? |
Contributor
|
ack, will review |
Contributor
Author
thx! Could you take another look at this pr #2807 ? |
Contributor
Author
hi, @iamzainhuda can you help me land the changes? Are there any existing issues I should address? |
Contributor
|
@iamzainhuda has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
iamzainhuda
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KJT.lengths is modified by mean pooling callback. When some embeddings use mean pooling and others use sum pooling, KJT.lengths will be incorrect.