Add missing fields to KJT's PyTree flatten/unflatten logic for VBE KJT#2952
Closed
jd7-tr wants to merge 1 commit intometa-pytorch:mainfrom
Closed
Add missing fields to KJT's PyTree flatten/unflatten logic for VBE KJT#2952jd7-tr wants to merge 1 commit intometa-pytorch:mainfrom
jd7-tr wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74295924 |
jd7-tr
added a commit
to jd7-tr/torchrec
that referenced
this pull request
Jun 20, 2025
meta-pytorch#2952) Summary: # Context * Currently torchrec IR serializer does not support exporting variable batch KJT, because the `stride_per_rank_per_rank` and `inverse_indices` fields are needed for deserializing VBE KJTs but they are included in the KJT's PyTree flatten/unflatten function. * The diff updates KJT's PyTree flatten/unflatten function to include `stride_per_rank_per_rank` and `inverse_indices`. # Ref Differential Revision: D74295924
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74295924 |
jd7-tr
added a commit
to jd7-tr/torchrec
that referenced
this pull request
Jun 21, 2025
meta-pytorch#2952) Summary: # Context * Currently torchrec IR serializer does not support exporting variable batch KJT, because the `stride_per_rank_per_rank` and `inverse_indices` fields are needed for deserializing VBE KJTs but they are included in the KJT's PyTree flatten/unflatten function. * The diff updates KJT's PyTree flatten/unflatten function to include `stride_per_rank_per_rank` and `inverse_indices`. # Ref Differential Revision: D74295924
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74295924 |
jd7-tr
added a commit
to jd7-tr/torchrec
that referenced
this pull request
Jun 23, 2025
meta-pytorch#2952) Summary: # Context * Currently torchrec IR serializer does not support exporting variable batch KJT, because the `stride_per_rank_per_rank` and `inverse_indices` fields are needed for deserializing VBE KJTs but they are included in the KJT's PyTree flatten/unflatten function. * The diff updates KJT's PyTree flatten/unflatten function to include `stride_per_rank_per_rank` and `inverse_indices`. # Ref Reviewed By: TroyGarden Differential Revision: D74295924
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74295924 |
jd7-tr
added a commit
to jd7-tr/torchrec
that referenced
this pull request
Jun 23, 2025
meta-pytorch#2952) Summary: Pull Request resolved: meta-pytorch#2952 # Context * Currently torchrec IR serializer does not support exporting variable batch KJT, because the `stride_per_rank_per_rank` and `inverse_indices` fields are needed for deserializing VBE KJTs but they are included in the KJT's PyTree flatten/unflatten function. * The diff updates KJT's PyTree flatten/unflatten function to include `stride_per_rank_per_rank` and `inverse_indices`. # Ref Reviewed By: TroyGarden Differential Revision: D74295924
jd7-tr
force-pushed
the
export-D74295924
branch
2 times, most recently
from
b4dfa13 to
1bc6ae0
Compare
jd7-tr
added a commit
to jd7-tr/torchrec
that referenced
this pull request
Jun 26, 2025
meta-pytorch#2952) Summary: # Context * Currently torchrec IR serializer does not support exporting variable batch KJT, because the `stride_per_rank_per_rank` and `inverse_indices` fields are needed for deserializing VBE KJTs but they are included in the KJT's PyTree flatten/unflatten function. * The diff updates KJT's PyTree flatten/unflatten function to include `stride_per_rank_per_rank` and `inverse_indices`. # Ref Reviewed By: TroyGarden Differential Revision: D74295924
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74295924 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74295924 |
jd7-tr
added a commit
to jd7-tr/torchrec
that referenced
this pull request
Jul 9, 2025
meta-pytorch#2952) Summary: # Context * Currently torchrec IR serializer does not support exporting variable batch KJT, because the `stride_per_rank_per_rank` and `inverse_indices` fields are needed for deserializing VBE KJTs but they are included in the KJT's PyTree flatten/unflatten function. * The diff updates KJT's PyTree flatten/unflatten function to include `stride_per_rank_per_rank` and `inverse_indices`. # Ref Reviewed By: TroyGarden Differential Revision: D74295924
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74295924 |
meta-pytorch#2952) Summary: # Context * Currently torchrec IR serializer does not support exporting variable batch KJT, because the `stride_per_rank_per_rank` and `inverse_indices` fields are needed for deserializing VBE KJTs but they are included in the KJT's PyTree flatten/unflatten function. * The diff updates KJT's PyTree flatten/unflatten function to include `stride_per_rank_per_rank` and `inverse_indices`. # Ref Reviewed By: TroyGarden Differential Revision: D74295924
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74295924 |
Contributor
|
This pull request has been reverted by d797031. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Context
stride_per_rank_per_rankandinverse_indicesfields are needed for deserializing VBE KJTs but they are included in the KJT's PyTree flatten/unflatten function.stride_per_rank_per_rankandinverse_indices.Ref
Differential Revision: D74295924