Swap CPU TBE lookup kernel with SSD TBE lookup kernel for tables being offloaded to SSD #2965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g offloaded to SSD Summary: Once, we TW shard the SSD tables here: D74444699 along with remaining tables, we traverse the model def and swap cpu tbe look up kernel for these ssd tables with the ssd look up kernel introduced here: D74536076 during TGIF publish If and when SSD embedding db based look up kernel is open sourced we can directly map the ssd tbe kernel during sharding without any swap Differential Revision: D74537413
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74537413 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Once, we TW shard the SSD tables here: D74444699 along with remaining tables, we traverse the model def and swap cpu tbe look up kernel for these ssd tables with the ssd look up kernel introduced here: D74536076 during TGIF publish
If and when SSD embedding db based look up kernel is open sourced we can directly map the ssd tbe kernel during sharding without any swap
Differential Revision: D74537413