Account for cache load factor in memory estimate #3035
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75893983 |
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Jun 3, 2025
Summary: The actual L1 cache allocated is determined by cache load factor and ceiled by max_l1_cache_size config. This diff addresses that to improve the memory estimate. Reviewed By: emlin Differential Revision: D75893983
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Jun 3, 2025
Summary: The actual L1 cache allocated is determined by cache load factor and ceiled by max_l1_cache_size config. This diff addresses that to improve the memory estimate. Reviewed By: emlin Differential Revision: D75893983
|
This pull request was exported from Phabricator. Differential Revision: D75893983 |
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Jun 3, 2025
Summary: Pull Request resolved: pytorch#3035 The actual L1 cache allocated is determined by cache load factor and ceiled by max_l1_cache_size config. This diff addresses that to improve the memory estimate. Reviewed By: emlin Differential Revision: D75893983
|
This pull request was exported from Phabricator. Differential Revision: D75893983 |
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Jun 3, 2025
Summary: Pull Request resolved: pytorch#3035 The actual L1 cache allocated is determined by cache load factor and ceiled by max_l1_cache_size config. This diff addresses that to improve the memory estimate. Reviewed By: emlin Differential Revision: D75893983
Summary: the variable is kept optional str for "inf" Differential Revision: D75900311
Summary: Pull Request resolved: pytorch#3035 The actual L1 cache allocated is determined by cache load factor and ceiled by max_l1_cache_size config. This diff addresses that to improve the memory estimate. Reviewed By: emlin, duduyi2013 Differential Revision: D75893983
|
This pull request was exported from Phabricator. Differential Revision: D75893983 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The actual L1 cache allocated is determined by cache load factor and ceiled by max_l1_cache_size config.
This diff addresses that to improve the memory estimate.
Differential Revision: D75893983