Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement activation offloading and opt_in_bwd in knowledge_distillation recipes #1959

Open
felipemello1 opened this issue Nov 7, 2024 · 0 comments
Labels
community help wanted We would love the community's help completing this issue good first issue Good for newcomers

Comments

@felipemello1
Copy link
Contributor

Current knowledge distillation recipes don't have support for activation offloading and opt_in_bwd.

The implementation should be similar to the one in other recipes, like full_finetuning_distributed.

After enabling it in the recipe, it should also be enabled in the configs related to KD.

PRs with reference implementation:
activation offloading: #1847
opt_in_bwd implementation: #1833

KD recipes:
https://github.com/pytorch/torchtune/blob/main/recipes/knowledge_distillation_single_device.py
https://github.com/pytorch/torchtune/blob/main/recipes/knowledge_distillation_distributed.py

@felipemello1 felipemello1 added community help wanted We would love the community's help completing this issue good first issue Good for newcomers labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community help wanted We would love the community's help completing this issue good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant