Update ax_multiobjective_nas_tutorial.py to use TensorboardMetric #2985
Conversation
Ax's TensorboardCurveMetric is going away soon and is replaced by TensorboardMetric
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2985
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e428e6c with merge base a66464b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
What is the minimum Ax version with which this will work? May want to add this to the requirements so that this doesn't install an old version due to possible dependency version conflicts: https://github.com/pytorch/tutorials/blob/main/.ci/docker/requirements.txt#L33
Ensure Ax is a version with TensorboardMetric
There was a problem hiding this comment.
Minor newline nit but otherwise lgtm, assuming build passes.
@mpolson64 were you able to run the tutorial locally to validate that this works as intended?
Yup, ran totally fine on my conda env with minimal dependencies |
…nsorboardCurveMetric Summary: D57922964 reaped the old TB integration, updating the tutorial to use the new TB integration. This is more or less identical to what we did for pytorch/tutorials here pytorch/tutorials#2985 Differential Revision: D60767153
…nsorboardCurveMetric (facebook#2635) Summary: Pull Request resolved: facebook#2635 D57922964 reaped the old TB integration, updating the tutorial to use the new TB integration. This is more or less identical to what we did for pytorch/tutorials here pytorch/tutorials#2985 Reviewed By: Balandat Differential Revision: D60767153
…nsorboardCurveMetric (facebook#2635) Summary: Pull Request resolved: facebook#2635 D57922964 reaped the old TB integration, updating the tutorial to use the new TB integration. This is more or less identical to what we did for pytorch/tutorials here pytorch/tutorials#2985 Reviewed By: Balandat Differential Revision: D60767153
…nsorboardCurveMetric (facebook#2635) Summary: Pull Request resolved: facebook#2635 D57922964 reaped the old TB integration, updating the tutorial to use the new TB integration. This is more or less identical to what we did for pytorch/tutorials here pytorch/tutorials#2985 Reviewed By: Balandat Differential Revision: D60767153
…nsorboardCurveMetric (#2635) Summary: Pull Request resolved: #2635 D57922964 reaped the old TB integration, updating the tutorial to use the new TB integration. This is more or less identical to what we did for pytorch/tutorials here pytorch/tutorials#2985 Reviewed By: Balandat Differential Revision: D60767153 fbshipit-source-id: fe2ca5db693ee51cad35ca79b076c283dc76da2f
Ax's TensorboardCurveMetric is going away soon and is replaced by TensorboardMetric
Description
My team (Adaptive Experimentation) wrote this tutorial a number of years ago. We have since updated the way our library Ax interfaces with Tensorboard and are interested in reaping our old class TensorboardCurveMetric. In order to ensure this doesnt break our tutorial on the pytorch website we want to proactively update this tutorial to use our new class TensorboardMetric.
I tested this locally, but let me know if I can produce a more formal test plan.
cc @Balandat @dme65
Checklist
The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")Labels from the issue that this PR is fixing are added to this pull request