Handled the case when import statement contains '.ts' and '.tsx' extensions in path (#288)

Co-authored-by: Abhishek <[email protected]>
Co-authored-by: Sean Ryan <[email protected]>

Author: 3 people

CHANGELOG.md

@@ -1,3 +1,7 @@
+## [9.0.6] - 26 Jun 2023
+
+- Handled the case when import statement contains '.ts' and '.tsx' extensions in path
+
 ## [9.0.5] - 24 Jun 2023
 
 - Add --ignoreLocallyUsed flag which means that exports which are used in the same file they are defined in won't be reported as unused

example/import-with-ts-extension/src/a.ts

@@ -0,0 +1 @@
+export let a = 5;

example/import-with-ts-extension/src/b.ts

@@ -0,0 +1 @@
+import {a} from "./a.js";

example/import-with-ts-extension/src/unused-1.ts

@@ -0,0 +1 @@
+export const unused1 = 1;

example/import-with-ts-extension/src/unused-2.ts

@@ -0,0 +1 @@
+export const unused2 = 1;

example/import-with-ts-extension/tsconfig.json

@@ -0,0 +1,15 @@
+{
+  "compilerOptions": {
+    "baseUrl": ".",
+    "target": "es5",
+    "noEmit": true,
+    "noImplicitAny": true,
+    "strictNullChecks": true,
+    "moduleResolution": "node",
+    "paths": {
+      "utils": ["utils/src"],
+      "utils/*": ["utils/src/*"]
+    },
+  },
+  "include": ["src/**/*.ts"],
+}

ispec/run.sh

@@ -18,6 +18,9 @@ function install_and_run_itest()
 {
     npm ci > /dev/null && run_itest
 }
+pushd ../example/import-with-ts-extension
+run_itest
+popd
 
 pushd ../example/simple-zero-issues
 run_itest_expect_zero_issues

src/analyzer.ts

@@ -9,7 +9,7 @@ import {
   indexCandidateExtensions,
   indexCandidates,
   removeExportStarPrefix,
-  removeFileExtensionToAllowForJs,
+  removeFileExtensionToAllowForJsTsJsxTsx,
 } from './parser/util';
 
 export { Analysis } from './types';
@@ -78,7 +78,7 @@ const getExportMap = (files: File[]): ExportMap => {
 const processImports = (file: File, exportMap: ExportMap): void => {
   Object.keys(file.imports).forEach((key) => {
     const importedFileExports =
-      exportMap[removeFileExtensionToAllowForJs(key)] || null;
+      exportMap[removeFileExtensionToAllowForJsTsJsxTsx(key)] || null;
 
     let ex = importedFileExports?.exports || null;
 

src/parser/util.ts

@@ -27,9 +27,9 @@ export const indexCandidateExtensions = [
   '.mjs',
 ];
 
-export function removeFileExtensionToAllowForJs(path: string): string {
+export function removeFileExtensionToAllowForJsTsJsxTsx(path: string): string {
   // ref: https://www.typescriptlang.org/docs/handbook/esm-node.html
-  const extensionsToStrip = ['.js', '.cjs', '.mjs'];
+  const extensionsToStrip = ['.js', '.jsx', '.cjs', '.mjs', '.ts', '.tsx'];
 
   return stripExtensionsFromPath(extensionsToStrip, path);
 }