Fix oneOf, multipleOf string modifiers

Author: ctapobep

.gitignore

@@ -1,3 +1,4 @@
 .idea/
 target/
-*.iml
+*.iml
+*.versionsBackup

README.md

@@ -59,4 +59,8 @@ from("A", "B", "C", "D").sample(2)
 > ["B", "D"]
 ```
 
-Support: Java5+
+### Special thanks
+
+To keep the lib tiny and get rid of extra dependencies (there are no 
+transitive dependencies) some of the code was borrowed from these libs:
+Commons Lang, Commons Math. Hail to opensource!

datagen-java8types/pom.xml

@@ -5,7 +5,7 @@
     <parent>
         <artifactId>qala-datagen-parent</artifactId>
         <groupId>io.qala.datagen</groupId>
-        <version>1.0-SNAPSHOT</version>
+        <version>1.0.0</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
 

datagen-java8types/src/main/java/io/qala/datagen/RandomDateTime.java

@@ -1,5 +1,6 @@
 package io.qala.datagen;
 
+
 public class RandomDateTime extends RandomValue {
     private RandomDateTime(Long min, Long max) {
         super(min, max);

datagen/pom.xml

@@ -5,7 +5,7 @@
     <parent>
         <artifactId>qala-datagen-parent</artifactId>
         <groupId>io.qala.datagen</groupId>
-        <version>1.0-SNAPSHOT</version>
+        <version>1.0.0</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
 

datagen/src/main/java/io/qala/datagen/StringModifier.java

@@ -46,7 +46,7 @@ static StringModifier oneOf(String chars) {
         static StringModifier oneOf(final char... chars) {
             return new StringModifier() {
                 @Override public String modify(String original) {
-                    int index = upTo(original.length()).integer();
+                    int index = upTo(original.length() - 1).integer();
                     String symbol = CommonsLang3RandomStringUtils.random(1, chars);
                     return new StringBuilder(original).replace(index, index + 1, symbol).toString();
                 }
@@ -63,7 +63,7 @@ static StringModifier multipleOf(final char... chars) {
                     int nOfSymbols = between(1, original.length()).integer();
                     StringBuilder stringBuilder = new StringBuilder(original);
                     for (int i = 0; i < nOfSymbols; i++) {
-                        int index = upTo(original.length()).integer();
+                        int index = upTo(original.length() - 1).integer();
                         String symbol = CommonsLang3RandomStringUtils.random(1, chars);
                         stringBuilder.replace(index, index + 1, symbol);
                     }

datagen/src/test/java/io/qala/datagen/RandomValueTest.java

@@ -107,6 +107,9 @@ public class RandomValueTest {
         @Test void doesNotModifyLengthIfAddsSpecialSymbol() {
             assertThat(length(100).with(specialSymbol()).english().length(), equalTo(100));
         }
+        @Test void doesNotModifyLengthIfAddsMultipleChars() {
+            assertThat(length(100).with(multipleOf("!!_#")).english().length(), equalTo(100));
+        }
         @Test void addsOneOfPassedSymbols() {
             assertThat(length(100).with(oneOf(",")).english(), containsString(","));
         }

pom.xml

@@ -7,10 +7,29 @@
     <groupId>io.qala.datagen</groupId>
     <artifactId>qala-datagen-parent</artifactId>
     <packaging>pom</packaging>
-    <version>1.0-SNAPSHOT</version>
+    <version>1.0.0</version>
+
+    <licenses>
+        <license>
+            <name>The Apache License, Version 2.0</name>
+            <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
+        </license>
+    </licenses>
+    <name>Qala Datagen</name>
+    <description>Java lib to generate random data to facilitate Randomized Testing.</description>
+    <url>https://bitbucket.org/qala/datagen/</url>
+    <developers>
+        <developer>
+            <name>Stanislav Bashkyrtsev</name>
+            <email>[email protected]</email>
+            <organization>Qala</organization>
+            <organizationUrl>http://qala.io</organizationUrl>
+        </developer>
+    </developers>
+
     <modules>
         <module>datagen</module>
-        <module>datagen-java8types</module>
+        <!--<module>datagen-java8types</module>-->
     </modules>
 
     <properties>
@@ -54,6 +73,20 @@
                     </execution>
                 </executions>
             </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-javadoc-plugin</artifactId>
+                <version>2.10.3</version>
+                <executions>
+                    <execution>
+                        <id>generate-javadocs</id>
+                        <phase>verify</phase>
+                        <goals>
+                            <goal>jar</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
             <plugin>
                 <groupId>org.sonatype.plugins</groupId>
                 <artifactId>nexus-staging-maven-plugin</artifactId>
@@ -185,6 +218,8 @@
         </repository>
     </distributionManagement>
     <scm>
-        <url>https://bitbucket.org/qala/datagen</url>
+        <connection>scm:git:https://[email protected]/qala/datagen.git</connection>
+        <developerConnection>scm:git:https://[email protected]/qala/datagen.git</developerConnection>
+        <url>https://bitbucket.org/qala/datagen/</url>
     </scm>
 </project>