Skip to content

Commit a6717de

Browse files
authored
Deactivate search functionality in the measurements view (#1169)
Pooled measurements with large sample numbers (100+) lead to a non-responsive view and breakage of the frontend. This PR simplifies the database queries by disabling user filtering on each property of a measurement. Co-authored-by: KochTobi <[email protected]>
1 parent 2e46dc3 commit a6717de

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

project-management-infrastructure/src/main/java/life/qbic/projectmanagement/infrastructure/experiment/measurement/MeasurementLookupImplementation.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,8 @@ public List<ProteomicsMeasurement> findProteomicsMeasurementsBySampleIds(String
7070
}
7171
return order;
7272
}).toList();
73-
Specification<ProteomicsMeasurement> filterSpecification = generateProteomicsFilterSpecification(
74-
sampleIds, filter);
75-
return pxpMeasurementJpaRepo.findAll(filterSpecification,
73+
//FIXME ignores the filter
74+
return pxpMeasurementJpaRepo.findAll(ProteomicsMeasurementSpec.containsSampleId(sampleIds),
7675
new OffsetBasedRequest(offset, limit, Sort.by(orders))).getContent();
7776
}
7877

@@ -156,9 +155,8 @@ public List<NGSMeasurement> queryNGSMeasurementsBySampleIds(String filter,
156155
}
157156
return order;
158157
}).toList();
159-
Specification<NGSMeasurement> filterSpecification = generateNGSFilterSpecification(
160-
sampleIds, filter);
161-
return ngsMeasurementJpaRepo.findAll(filterSpecification,
158+
//FIXME ignores the filter
159+
return ngsMeasurementJpaRepo.findAll(NgsMeasurementSpec.containsSampleId(sampleIds),
162160
new OffsetBasedRequest(offset, limit, Sort.by(orders))).getContent();
163161
}
164162

user-interface/src/main/java/life/qbic/datamanager/views/projects/project/measurements/MeasurementMain.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,8 @@ private void initSearchFieldAndButtonBar() {
209209

210210
Span buttonBar = new Span(downloadButton, editButton, deleteButton, registerMeasurementButton);
211211
buttonBar.addClassName("button-bar");
212-
Span buttonsAndSearch = new Span(measurementSearchField, buttonBar);
212+
// measurementSearchField disabled as the search functionality is turned off due to efficiency reasons
213+
Span buttonsAndSearch = new Span(/*measurementSearchField,*/ buttonBar);
213214
buttonsAndSearch.addClassName("buttonAndField");
214215
measurementsSelectedInfoBox.addClassName("info");
215216
setSelectedMeasurementsInfo(0);

0 commit comments

Comments
 (0)