Skip to content

Commit c878928

Browse files
KochTobisven1103
andauthored
Fix condition comparison and fail for duplicate conditions (#1291)
Co-authored-by: KochTobi <[email protected]> Co-authored-by: Sven F. <[email protected]>
1 parent fbd7bfb commit c878928

File tree

1 file changed

+3
-2
lines changed
  • project-management/src/main/java/life/qbic/projectmanagement/domain/model/experiment

1 file changed

+3
-2
lines changed

project-management/src/main/java/life/qbic/projectmanagement/domain/model/experiment/Condition.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import java.util.ArrayList;
77
import java.util.Collection;
88
import java.util.Collections;
9+
import java.util.HashSet;
910
import java.util.List;
1011
import java.util.Objects;
1112
import java.util.Optional;
@@ -104,8 +105,8 @@ public boolean equals(Object o) {
104105
}
105106

106107
Condition condition = (Condition) o;
107-
108-
return this.variableLevels.equals(condition.variableLevels);
108+
//we do not care about the order when comparing
109+
return new HashSet<>(variableLevels).equals(new HashSet<>(condition.variableLevels));
109110
}
110111

111112
@Override

0 commit comments

Comments
 (0)