fix(version): log last release by tag name alphabetically instead of date

qdm12 · qdm12 · commit 09c47c740c68 · 2024-08-09T07:43:48.000Z
diff --git a/internal/version/version.go b/internal/version/version.go
@@ -5,6 +5,7 @@ import (
 	"errors"
 	"fmt"
 	"net/http"
+	"sort"
 	"time"
 
 	"github.com/qdm12/gluetun/internal/models"
@@ -49,13 +50,17 @@ func getLatestRelease(ctx context.Context, client *http.Client) (tagName, name s
 	if err != nil {
 		return "", "", time, err
 	}
+	// Sort releases by tag names (semver)
+	sort.Slice(releases, func(i, j int) bool {
+		return releases[i].TagName > releases[j].TagName
+	})
 	for _, release := range releases {
 		if release.Prerelease {
 			continue
 		}
 		return release.TagName, release.Name, release.PublishedAt, nil
 	}
-	return "", "", time, errReleaseNotFound
+	return "", "", time, fmt.Errorf("%w", errReleaseNotFound)
 }
 
 var errCommitNotFound = errors.New("commit not found")

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ import (`
`5`	`5`	`"errors"`
`6`	`6`	`"fmt"`
`7`	`7`	`"net/http"`
	`8`	`+ "sort"`
`8`	`9`	`"time"`
`9`	`10`
`10`	`11`	`"github.com/qdm12/gluetun/internal/models"`
`@@ -49,13 +50,17 @@ func getLatestRelease(ctx context.Context, client *http.Client) (tagName, name s`
`49`	`50`	`if err != nil {`
`50`	`51`	`return "", "", time, err`
`51`	`52`	`}`
	`53`	`+ // Sort releases by tag names (semver)`
	`54`	`+ sort.Slice(releases, func(i, j int) bool {`
	`55`	`+ return releases[i].TagName > releases[j].TagName`
	`56`	`+ })`
`52`	`57`	`for _, release := range releases {`
`53`	`58`	`if release.Prerelease {`
`54`	`59`	`continue`
`55`	`60`	`}`
`56`	`61`	`return release.TagName, release.Name, release.PublishedAt, nil`
`57`	`62`	`}`
`58`		`- return "", "", time, errReleaseNotFound`
	`63`	`+ return "", "", time, fmt.Errorf("%w", errReleaseNotFound)`
`59`	`64`	`}`
`60`	`65`
`61`	`66`	`var errCommitNotFound = errors.New("commit not found")`