explicitly discard return value when releasing

qgis · Feb 13, 2025 · f6965e2 · f6965e2
1 parent 4b4cb2f
commit f6965e2
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/core/stac/qgsstacdataitems.cpp b/src/core/stac/qgsstacdataitems.cpp
@@ -178,7 +178,10 @@ void QgsStacItemItem::setStacItem( std::unique_ptr< QgsStacObject > &object )
 {
   QgsStacItem *item = dynamic_cast<QgsStacItem *>( object.get() );
   if ( item )
-    object.release();
+  {
+    // release object, mStacItem will take ownership of the successfully cast item
+    ( void )object.release();
+  }
 
   mStacItem.reset( item );
   updateToolTip();
@@ -463,7 +466,10 @@ void QgsStacCatalogItem::setStacCatalog( std::unique_ptr< QgsStacObject > &objec
 {
   QgsStacCatalog *catalog = dynamic_cast<QgsStacCatalog *>( object.get() );
   if ( catalog )
-    object.release();
+  {
+    // release object, mStacCatalog will take ownership of the successfully cast catalog
+    ( void )object.release();
+  }
 
   mStacCatalog.reset( catalog );
   if ( mStacCatalog )