From f6965e278f82b6fe7b2c08a8cc1fee3abad6e6d3 Mon Sep 17 00:00:00 2001
From: uclaros <uclaros@gmail.com>
Date: Mon, 10 Feb 2025 18:01:57 +0200
Subject: [PATCH] explicitly discard return value when releasing

---
 src/core/stac/qgsstacdataitems.cpp | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/core/stac/qgsstacdataitems.cpp b/src/core/stac/qgsstacdataitems.cpp
index 8ae76c336cb0..8908c3885842 100644
--- a/src/core/stac/qgsstacdataitems.cpp
+++ b/src/core/stac/qgsstacdataitems.cpp
@@ -178,7 +178,10 @@ void QgsStacItemItem::setStacItem( std::unique_ptr< QgsStacObject > &object )
 {
   QgsStacItem *item = dynamic_cast<QgsStacItem *>( object.get() );
   if ( item )
-    object.release();
+  {
+    // release object, mStacItem will take ownership of the successfully cast item
+    ( void )object.release();
+  }
 
   mStacItem.reset( item );
   updateToolTip();
@@ -463,7 +466,10 @@ void QgsStacCatalogItem::setStacCatalog( std::unique_ptr< QgsStacObject > &objec
 {
   QgsStacCatalog *catalog = dynamic_cast<QgsStacCatalog *>( object.get() );
   if ( catalog )
-    object.release();
+  {
+    // release object, mStacCatalog will take ownership of the successfully cast catalog
+    ( void )object.release();
+  }
 
   mStacCatalog.reset( catalog );
   if ( mStacCatalog )