Skip to content

Fix/wms provider url decoding #62446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fix/wms provider url decoding #62446

wants to merge 10 commits into from

Conversation

benoitdm-oslandia
Copy link
Collaborator

This closes #62310 and reopens #59144 plus some changes:

  • rebase from master
  • remove merge and revert commits
  • squash some commits
  • fix qgshttpheaders accordingly
  • add tests

closes #31192
closes #59143

cc @cioddi

@benoitdm-oslandia benoitdm-oslandia mentioned this pull request Jun 27, 2025
Closed
benoitdm-oslandia
benoitdm-oslandia commented Jun 27, 2025
View reviewed changes
@benoitdm-oslandia benoitdm-oslandia mentioned this pull request Jun 27, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 27, 2025 •
edited
Loading

🍎 MacOS Qt6 builds

Download MacOS Qt6 builds of this PR for testing.
This installer is not signed, control+click > open the app to avoid the warning
(Built from commit 739c6ec)

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 739c6ec)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 739c6ec)

@github-actions github-actions bot added this to the 3.46.0 milestone Jun 27, 2025
@benoitdm-oslandia benoitdm-oslandia self-assigned this Jul 1, 2025
cioddi and others added 10 commits July 1, 2025 11:49
@cioddi @benoitdm-oslandia
ensure values in QgsDataSourceUri are URL-encoded when assigned and p…
f43bad1 
…roperly decoded when retrieved, preventing any potential loss of information.
@cioddi @benoitdm-oslandia
fix faulty assertion in tests/src/core/testqgsdatasourceuri.cpp
6ee3e72 
URl-encoded in URL-parameter values characters will be URL-decoded on retrieval.
@cioddi @benoitdm-oslandia
fix faulty assertion of URI parameter values not being fully URL-enco…
ade7904 
…ded in tests/src/providers/testqgswmsprovider.cpp
@cioddi @benoitdm-oslandia
move QUrl::toPercentEncoding and QUrl::fromPercentEncoding steps from…
fd7c2bf 
… QgsDataSourceUri param setter and getter functions to URI serialization QgsDataSourceUri::encodedUri()
@cioddi @benoitdm-oslandia
make sure QgsDataSourceUri values are FullyUrlDecoded when parsing Qg…
fa7f98a 
…sDataSourceUri strings in QgsDataSourceUri::setEncodedUri
@cioddi @benoitdm-oslandia
fix(test): add/adjust tests for url encoding
3d392af 
add decoding step before adding the "url" value to QgsDataSourceUri in TestQgsIdentify::identifyVectorTile(), as QgsDataSourceUri now reliably returns the values that were provided.

adjust tests to QgsDataSourceUri full value URL-encoding

fix test tests/src/core/testqgshttpheaders.cpp

fix test tests/src/core/testqgssensorthingsconnection.cpp

fix test tests/src/core/testqgstiledsceneconnection.cpp

fix test tests/src/core/testqgsvectortileconnection.cpp

fix test tests/src/python/test_qgsvectortile.py

fix test tests/src/server/wms/test_qgsserver_wms_parameters.cpp

fix tests tests/src/core/testqgshttpheaders.cpp

fix most tests in tests/src/core/testqgsvectortilelayer.cpp
@cioddi @benoitdm-oslandia
fix double URL-encoding issue with curly braces in z,x,y placeholders…
4de79c5 
… of VectorTile Sources in QgsDataSurceUri
@benoitdm-oslandia
fix(QgsProjectStorageRegistry): project uri can be urlencoded and sta…
a3b523d 
…rts with XXX%3A
@benoitdm-oslandia
fix(httpheaders): add missing urlencode to headers when updating QUrl…
2b40e3a 
…Query
@benoitdm-oslandia
test(qgsdatasourceuri): add uri in uri test
739c6ec
@benoitdm-oslandia benoitdm-oslandia force-pushed the fix/wms-provider-url-decoding branch from 04ed226 to 739c6ec Compare July 1, 2025 11:17
@github-actions GitHub Actions
Copy link
Contributor

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cioddi cioddi cioddi left review comments

@nirvn nirvn Awaiting requested review from nirvn

@troopa81 troopa81 Awaiting requested review from troopa81

Assignees

@benoitdm-oslandia benoitdm-oslandia

Labels
stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Milestone
3.46.0
Development

Successfully merging this pull request may close these issues.

inconsistent URL encoding/decoding with WMS sources Add WMS server fails with QGIS Server with Postgresql project
2 participants
@benoitdm-oslandia @cioddi