Use cxx20 standard for build #62468
Use cxx20 standard for build #62468
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
| # require c++17 | ||
| target_compile_features(qgis_3d PRIVATE cxx_std_17) | ||
| # require c++20 | ||
| target_compile_features(qgis_3d PRIVATE cxx_std_20) |
There was a problem hiding this comment.
I think we should kill most of these for individual targets.
We should only specify it for targets that actually make use of c++20 features (and flag it PUBLIC if this needs to propagate to downstream targets). This can also just be specified on the pdf4qt target -- or for simplicity on the qgis_core target.
I don't see any risks involved with that (worst case build will fail for targets where we forgot to specify this)
|
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
github-actions
bot
added
the
stale
The main motivation here is allowing us to drop the downstream patches adding < cxx20 support to pdf4qt, which will allow us to resync that library (after moving the main builds to qt 6 only, that is)
But the secondary benefit is that we'll be able to cleanup a bunch of cxx20 todos in the code, including replacing custom equality operators with compiler default ones.