Investigate Possible Numerical Instability in 2q and 3q analytical decompositions #6770
Assignees
Labels
kind/bug-report
Something doesn't seem to work.
no QC knowledge needed
Want to contribute to Cirq, but don't know quantum computing? This issue is for you.
triage/accepted
there is consensus amongst maintainers that this is a real bug or a reasonable feature to add
triage/needs-more-evidence
[feature requests] this seems plausible but maintainers are not convinced about the use cases yet
Comments
NoureldinYosri
added
kind/bug-report
|
Hi, I would like to take this up. |
|
@RahilJain1366 thanks for offering to help. I assigned the task to you |
|
Thank you @NoureldinYosri for assigning it me. I wanted to confirm my understanding. I need to replicate the two_qubit_matrix_to_cz_operations and three_qubit_matrix_to_operations on quantum_shannon_decomposition in an older version of numpy? Am I right? |
|
this is a start ... see if you can use an old version of numpy to make the tests marked in #6767 fail ... then if you can propose a fix |
NoureldinYosri
added
triage/accepted
|
@NoureldinYosri Could you please assign me to this issue as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After adding
two_qubit_matrix_to_cz_operationsandthree_qubit_matrix_to_operationsas base cases forquantum_shannon_decomposition, some tests started to become flaky #6765. The tests pass with new versions of numpy and fail with older versions. For now I marked those tests withxfailuntil we are in state where we run tests with only newer numpy versions. however there might be some numerical instabilities in those methods that we may be able to fix.The text was updated successfully, but these errors were encountered: