Starts deprecating pass_operations_over for PauliString and PauliStringPhasor #7294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babacry
force-pushed
the
depre_pass_op
branch
2 times, most recently
from
ffe2b94 to
1d14cbe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7294 +/- ##
==========================================
- Coverage 98.67% 98.66% -0.01%
==========================================
Files 1108 1108
Lines 96220 96107 -113
==========================================
- Hits 94942 94827 -115
- Misses 1278 1280 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi reviewers, I intended to deprecate the class function in the PR as
The deprecating timeline is from v1.5 (starts warning) -> v2.0 (fully remove). Wonder if this matches the general deprecating process of Cirq. |
|
@Strilanc @NoureldinYosri @pavoljuhas wonder if you could help review this pr? this is part of #6946 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts deprecating all pass_operations_over().
pass_operations_over class function for PauliString* Classes is supposed to be replaced by conjuaged_by(), after(), before(). And the function itself is confusing and misleading in terms of the input order (see #2351).
Context: #7123 and #2351.