#928: Define rows of matrix explicitly (#1089)

`synthesize_dual_basis` uses iterated `index` to infer matrix size,
which is not very readable: [issue
928](#928). This PR
defines `n_rows` explicitly.

---------

Co-authored-by: Michael Hucka <[email protected]>

Author: SamKChang

src/openfermion/contrib/representability/_multitensor.py

@@ -109,16 +109,17 @@ def synthesize_dual_basis(self):
             dual_data_values.extend(dval)
             inner_prod_data_values.append(float(dual_element.dual_scalar))
             bias_data_values.append(dual_element.constant_bias)
+        n_rows = len(self.dual_basis.elements)
         sparse_dual_operator = csr_matrix(
-            (dual_data_values, (dual_row_indices, dual_col_indices)), [index + 1, self.vec_dim]
+            (dual_data_values, (dual_row_indices, dual_col_indices)), [n_rows, self.vec_dim]
         )
 
         sparse_bias_vector = csr_matrix(
-            (bias_data_values, (range(index + 1), [0] * (index + 1))), [index + 1, 1]
+            (bias_data_values, (range(n_rows), [0] * n_rows)), [n_rows, 1]
         )
 
         sparse_innerp_vector = csr_matrix(
-            (inner_prod_data_values, (range(index + 1), [0] * (index + 1))), [index + 1, 1]
+            (inner_prod_data_values, (range(n_rows), [0] * (n_rows))), [n_rows, 1]
         )
 
         return sparse_dual_operator, sparse_bias_vector, sparse_innerp_vector