-
Notifications
You must be signed in to change notification settings - Fork 126
Open
Labels
area/devopsConcerns continuous integration, workflows, automation, maintenance, dev tools, etc.Concerns continuous integration, workflows, automation, maintenance, dev tools, etc.area/healthIssues and PRs related to code, repository, or project healthIssues and PRs related to code, repository, or project healthhelp wantedHelp with this would be appreciatedHelp with this would be appreciatedpriority/p3Low PriorityLow Priority
Description
Right now: requirements are "best effort" separated in a single requirements.txt file by arranging them under comment-headings for the various sub-packages
We could use pip's support for extras-require, e.g. pip install recirq[qaoa] so the extra requirements could be specified in a structured way. Specifically: I propose an extra-requirements.txt file in each submodule (i.e. experiment) containing that sub-packages extra requirements. These files could be parsed in setup.py to generate the extras_require argument to setuptools.setup.
Currently our notebooks pip install +github.com/quantumlib/recirq so that they work in a colab environment. We'll need to do the change stepwise to make sure the notebooks don't break
- add extra_requires but don't remove those requirements from install_requires
- update notebooks to pip install recirq with requisite extras, i.e.
pip install +github/recirq[qaoa] - Remove the extra requirements from install_requires so
pip install recirqonly gets you the minimal, base requirements.
cc @dstrain115
Metadata
Metadata
Assignees
Labels
area/devopsConcerns continuous integration, workflows, automation, maintenance, dev tools, etc.Concerns continuous integration, workflows, automation, maintenance, dev tools, etc.area/healthIssues and PRs related to code, repository, or project healthIssues and PRs related to code, repository, or project healthhelp wantedHelp with this would be appreciatedHelp with this would be appreciatedpriority/p3Low PriorityLow Priority